Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo project: Mini Editor (Android) #50

Merged
merged 16 commits into from
Jul 29, 2021
Merged

Demo project: Mini Editor (Android) #50

merged 16 commits into from
Jul 29, 2021

Conversation

imWildCat
Copy link
Contributor

@imWildCat imWildCat commented Jul 28, 2021 •
edited
Loading

This is a minimal Android demo project which only contains straightforward usages of ts-codegen.

Third-party dependencies used:

@imWildCat imWildCat changed the title Demo project: Add Android app for MiniEditor Demo project: Add Android app for Mini Editor Jul 28, 2021
@imWildCat imWildCat changed the title Demo project: Add Android app for Mini Editor Demo project: Mini Editor (Android) Jul 28, 2021
@imWildCat
Copy link
Contributor Author

@Foolment Should we include gradle-wrapper.jar in git? I find by default, it is included.

@imWildCat imWildCat marked this pull request as ready for review July 28, 2021 09:16
@imWildCat imWildCat enabled auto-merge (squash) July 28, 2021 09:19
@imWildCat imWildCat linked an issue Jul 28, 2021 that may be closed by this pull request
Demo Android project #46
Closed
@imWildCat imWildCat mentioned this pull request Jul 28, 2021
Closed
@imWildCat imWildCat disabled auto-merge July 29, 2021 04:40
@imWildCat imWildCat force-pushed the imWildCat/mini-editor-android branch from f86351a to 7ca659f Compare July 29, 2021 04:40
zhuorantan
zhuorantan approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@zhuorantan zhuorantan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript part LGTM!

@zhuorantan
Copy link
Contributor

The CI is failing because the output directory doesn't exist. Maybe we need to create the directory in this case.

@imWildCat
Copy link
Contributor Author

The CI is failing because the output directory doesn't exist. Maybe we need to create the directory in this case.

The path should exist because it has been checked into git. I'm setting up a linux VM to test it.

@zhuorantan
Copy link
Contributor

The path should exist because it has been checked into git.

Looks like it's the case issue? The checked out path is Generated but CI reported generated.

@imWildCat
Copy link
Contributor Author

The path should exist because it has been checked into git.

Looks like it's the case issue? The checked out path is Generated but CI reported generated.

Good catch! I'm fixing it!

@imWildCat imWildCat enabled auto-merge (squash) July 29, 2021 06:23
@imWildCat imWildCat merged commit 479a13e into main Jul 29, 2021
@imWildCat imWildCat deleted the imWildCat/mini-editor-android branch July 29, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuorantan zhuorantan zhuorantan approved these changes

@Foolment Foolment Awaiting requested review from Foolment

@haven2world haven2world Awaiting requested review from haven2world

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demo Android project
2 participants
@imWildCat @zhuorantan