Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prevent going to next stage when a warning is elevated to an error #2983

Merged

Conversation

timotheeguerin
Copy link
Member

fix #2972

@timotheeguerin timotheeguerin marked this pull request as ready for review March 5, 2024 16:54
@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 5, 2024

All changed packages have been documented.

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2983/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2983/

@timotheeguerin timotheeguerin enabled auto-merge (squash) March 12, 2024 21:50
@timotheeguerin timotheeguerin merged commit 00996bb into microsoft:main Mar 12, 2024
14 checks passed
@timotheeguerin timotheeguerin deleted the fix/warn-as-error-keep-going branch March 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--warn-as-error prevents next stage from running if it finds any warning
3 participants