Add /d to all cmd invocations to avoid autoruns. #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes microsoft/vcpkg#8268. |
|
I bet somebody depends on this behavior to not need to create a triplet/toolchain since it can be used to inject build flags via env variables. |
dfederm
approved these changes
Sep 19, 2023
data-queue
approved these changes
Sep 20, 2023
src/vcpkg/base/system.process.cpp
Outdated
| } | ||
|
|
||
| auto& rc_output = maybe_rc_output.value_or_exit(VCPKG_LINE_INFO); | ||
| if (rc_output.exit_code != 0) | ||
| { | ||
| Debug::println("Output:"); | ||
| Debug::println(rc_output.output); |
There was a problem hiding this comment.
I think it would be cleaner if we move printing the debug output before the if statement, since we print in both cases (see line 1305).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke a Microsoft internal customer.