[openssl] Enforce cmd for nmake #37716
Conversation
ports/openssl/windows/portfile.cmake
Outdated
| # Need cmd to pass quoted CC from nmake to mkbuildinf.pl, GH-37134 | ||
| find_program(CMD_EXECUTABLE cmd HINTS ENV PATH NO_DEFAULT_PATH REQUIRED) | ||
| set(ENV{COMSPEC} "${CMD_EXECUTABLE}") | ||
|
|
There was a problem hiding this comment.
Is this a general problem and should be moved into vcpkg_build_nmake ?
There was a problem hiding this comment.
I have the same question ;-) It could be moved one step further:
Is this a general problem for windows host and should be moved to vcpkg tool?
FrankXie05
added
the
category:port-bug
I think the answer is yes. See also microsoft/vcpkg-tool#1201 |
|
I think the right place to do this is somewhere around https://github.com/microsoft/vcpkg-tool/blob/de85ec90b8b8c12878dae776811392415f746314/src/vcpkg/base/system.process.cpp#L478 |
|
I probaly won't touch these parts of the tools soon. I'm not operating under MSVS. |
|
I think the tool is the right place but this is better than nothing and already done :). Thanks! |
Fixes #37134.
Fixes #35949.