-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[curl] x64-windows build failure with features brotli,c-ares,core,http2,mbedtls,non-http,openssl,schannel,ssh,ssl,sspi,tool,winssl after curl Fixes pkgconfig configuration file (#14350) #14681
Comments
Looking into this, thanks for reporting @StarGate-One |
@StarGate-One this doesn't seem to be a real issue; I think it is caused by not updating the libraries after a git pull. I recommend However, when looking at this issue, I did find an issue with libpq: #14685 |
I am trying on a fresh clone and see what happens. |
@strega-nil on this one, it still fails with the same issue, as fresh vanilla clone as of a few minutes ago, no previous ports installed.
Console log about the same: Error: Building package curl:x64-windows failed with: BUILD_FAILED |
@StarGate-One that's really odd... it works completely fine on my machine. Can you try the clean install anyways? Also, don't worry about renaming |
|
@strega-nil FYI
|
@PhoebeHui @Matioupi cc: @strega-nil
|
Hello, this looks like the same kind or error message I had in adding "fix" cases for the libcurl.pc file. Still I missed testinf those features and adding the same kind of search & replace fix. Will take care of it today. (and maybe refactor a little bit to make it more generic) |
Hello, This commit : #14681 Fixes the issue (only handle and tested for windows case at time, more work needed for other platforms). I decided to remove the -loptimized / -ldebug that were in the package stage libcurl.pc. Maybe a better fix would be to add those in the vcpkg_fixup_pkgconfig calls at the end of the portfile.cmake It also seems that the release/debug libcurl.pc at the package stage contains both the debug/release versions of the pthread libraries which is weird. |
OK - I got the fix from commit Matioupi@236dae5 PR First fix attempts for #14681 and got a new error😢 with zlib with brotlidec.lib and brotlicommon lib.
|
More fix here : Matioupi@fe90a39 |
I just tested a linux build and get no errors with the specific features and build order that were used. Still the result libcurl.pc do not contain references to brotli libs even when they are present and the feature was activated. Not sure if this requires a specific fix or not. |
Also, shouldn't the CONTROL section about brotli feature be changed from
to
in order to force brotli build when the feature is activated ? is there a rationale for not having it ? |
Thank you for the hard work👍👍👍😊😊😊 |
@StarGate-One, thanks for reporting this issue and figure out the repro steps! @Matioupi, could you help summit the fix? |
@PhoebeHui : I opened a new PR with the proposed fix : Phoe #14715 |
* Fix pkgconfig for windows debug build. Re-allow tool feature on non windows platforms * Fix tool feature * Modified debug/release prvate libs according to #14350 (comment) Added vcpkg_fixup_pkgconfig() according to #14350 (comment) * Delete portfile.cmake.orig * Fix pkgconfig * Revert "Fix pkgconfig" This reverts commit cb4da8b. * Bump port version to 3 * add missing system libs for windows. made case type coherent for ws2_32 * Fix build on x64-linux triplet * Reverted ws2_32 to Ws2_32 as discudssed in #14350 (comment) * More fixes for Linux build with features * Fix for feature c-ares * Formatting * First fix attemps for #14681 * More fix for #14681 (Windows only for now) * Add brotli dependcy when brotli feature is enabled * Fixed indentation Co-authored-by: Phoebe Ma <v-phma@microsoft.com>
* Fix pkgconfig for windows debug build. Re-allow tool feature on non windows platforms * Fix tool feature * Modified debug/release prvate libs according to microsoft/vcpkg#14350 (comment) Added vcpkg_fixup_pkgconfig() according to microsoft/vcpkg#14350 (comment) * Delete portfile.cmake.orig * Fix pkgconfig * Revert "Fix pkgconfig" This reverts commit cb4da8b. * Bump port version to 3 * add missing system libs for windows. made case type coherent for ws2_32 * Fix build on x64-linux triplet * Reverted ws2_32 to Ws2_32 as discudssed in microsoft/vcpkg#14350 (comment) * More fixes for Linux build with features * Fix for feature c-ares * Formatting * First fix attemps for microsoft/vcpkg#14681 * More fix for microsoft/vcpkg#14681 (Windows only for now) * Add brotli dependcy when brotli feature is enabled * Fixed indentation Co-authored-by: Phoebe Ma <v-phma@microsoft.com>
Issue
curl[brotli,c-ares,core,http2,mbedtls,non-http,openssl,schannel,ssh,ssl,sspi,tool,winssl] build failure after commit 878d7ea [curl] Fixes pkgconfig configuration file (#14350)
Host Environment
Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27044 for x64
Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29334 for x64
To Reproduce
Steps to reproduce the behavior:
git pull
.\vcpkg.exe install --x-use-aria2 --recurse --keep-going boost[core,mpi]:x64-windows boost-iostreams[core]:x64-windows boost-mpi[core]:x64-windows boost-parameter-python[core]:x64-windows boost-python[core]:x64-windows ctbignum[core]:x64-windows curl[brotli,c-ares,core,http2,mbedtls,non-http,openssl,schannel,ssh,ssl,sspi,tool,winssl]:x64-windows curlpp[core]:x64-windows date[core,remote-api]:x64-windows devil[core,jasper,lcms,libjpeg,libpng,openexr,tiff]:x64-windows directxtex[core,dx12,openexr]:x64-windows forge[core]:x64-windows freeimage[core]:x64-windows libarchive[bzip2,core,libxml2,lz4,lzma,lzo,openssl,zstd]:x64-windows libharu[core,notiffsymbols]:x64-windows liblzma[core]:x64-windows libpq[core,icu,nls,openssl,xml,zlib]:x64-windows libpqxx[core]:x64-windows libwebp[all,anim,core,cwebp,dwebp,extras,gif2webp,img2webp,info,mux,nearlossless,simd,swap16bitcsp,unicode,vwebp,vwebp-sdl]:x64-windows libxml2[core]:x64-windows libzip[bzip2,commoncrypto,core,default-aes,liblzma,mbedtls,openssl,wincrypto]:x64-windows libzippp[core]:x64-windows magnum-plugins[core,ddsimporter,devilimageimporter,drflacaudioimporter,freetypefont,harfbuzzfont,icoimporter,jpegimageconverter,jpegimporter,miniexrimageconverter,openddl,opengeximporter,pngimageconverter,pngimporter,stanfordimporter,stanfordsceneconverter,stbimageconverter,stbimageimporter,stlimporter]:x64-windows ogre[core]:x64-windows openexr[core]:x64-windows poco[core,pdf,postgresql]:x64-windows pybind11[core]:x64-windows python3[core]:x64-windows sdl2-image[core,libjpeg-turbo,libwebp,tiff]:x64-windows sdl2pp[core]:x64-windows shiva[core]:x64-windows tiff[core,tool]:x64-windows tmx[core]:x64-windows wxwidgets[core]:x64-windows
Failure logs
Starting package 9/34: curl:x64-windows
Building package curl[brotli,c-ares,core,http2,mbedtls,non-http,openssl,schannel,ssh,ssl,sspi,tool,winssl]:x64-windows...
-- Using cached D:/vcpkg_x64/vs2017/prod/downloads/curl-curl-315ee3fe75dade912b48a21ceec9ccda0230d937.tar.gz
-- Extracting source D:/vcpkg_x64/vs2017/prod/downloads/curl-curl-315ee3fe75dade912b48a21ceec9ccda0230d937.tar.gz
-- Applying patch 0002_fix_uwp.patch
-- Applying patch 0004_nghttp2_staticlib.patch
-- Applying patch 0005_remove_imp_suffix.patch
-- Applying patch 0006_fix_tool_depends.patch
-- Applying patch 0007_disable_tool_export_curl_target.patch
-- Applying patch 0009_fix_openssl_config.patch
-- Applying patch 0010_fix_othertests_cmake.patch
-- Applying patch 0011_fix_static_build.patch
-- Using source at D:/vcpkg_x64/vs2017/prod/buildtrees/curl/src/da0230d937-b280319101.clean
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: D:/vcpkg_x64/vs2017/prod/packages/curl_x64-windows/share/curl/curl-config
-- Using msys root at D:/vcpkg_x64/vs2017/prod/downloads/tools/msys2/17e91aa90d284835
-- Fixing pkgconfig file: D:/vcpkg_x64/vs2017/prod/packages/curl_x64-windows/lib/pkgconfig/libcurl.pc
-- CHECK_LIB_optimized D:/vcpkg_x64/vs2017/prod/packages/curl_x64-windows/lib/pthreadVC3.lib_RELEASE:CHECK_LIB_optimized D:/vcpkg_x64/vs2017/prod/packages/curl_x64-windows/lib/pthreadVC3.lib_RELEASE-NOTFOUND
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:233 (message):
Library "optimized
D:/vcpkg_x64/vs2017/prod/packages/curl_x64-windows/lib/pthreadVC3.lib" was
not found! If it is a system library use the SYSTEM_LIBRARIES parameter for
the vcpkg_fixup_pkgconfig call! Otherwise, correct the *.pc file
Call Stack (most recent call first):
scripts/cmake/vcpkg_fixup_pkgconfig.cmake:299 (vcpkg_fixup_pkgconfig_check_files)
ports/curl/portfile.cmake:170 (vcpkg_fixup_pkgconfig)
scripts/ports.cmake:136 (include)
Error: Building package curl:x64-windows failed with: BUILD_FAILED
Elapsed time for package curl:x64-windows: 1.169 min
No other logs produced
Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.
@PhoebeHui @Matioupi cc: @strega-nil
2020-11-20T05:54:15.3094113Z Starting package 156/237: curl:x64-windows
2020-11-20T05:54:15.3099330Z Building package curl[core,non-http,openssl,schannel,ssl,sspi,winssl]:x64-windows...
2020-11-20T05:54:15.3104446Z Building package curl[core,non-http,openssl,schannel,ssl,sspi,winssl]:x64-windows... done
2020-11-20T05:54:15.3109786Z Installing package curl[core,non-http,openssl,schannel,ssl,sspi,winssl]:x64-windows...
2020-11-20T05:54:15.3115017Z Installing package curl[core,non-http,openssl,schannel,ssl,sspi,winssl]:x64-windows... done
2020-11-20T05:54:15.3119841Z Elapsed time for package curl:x64-windows: 48.97 ms
The text was updated successfully, but these errors were encountered: