[curl] Fixes pkgconfig file #14715
Merged
[curl] Fixes pkgconfig file #14715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent) Added vcpkg_fixup_pkgconfig() according to microsoft#14350 (comment)
This reverts commit cb4da8b.
PhoebeHui
added
the
category:port-bug
PhoebeHui
requested changes
Nov 23, 2020
|
indentation should be fixed now... |
|
Alright, awesome! Thanks @Matioupi! |
|
@Matioupi Thank you very much😊👍👍👍 |
PhoebeHui
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent PR merge on curl (#14350) user @StarGate-One reported build failure with more features enabled. Especially brotli. This was missed in first PR because brotli feature do not enable brotli dependency build, and therefore tests on a vanilla tree do not fail (failure only occured if brotli was built before).
tested on Windows and Linux
to the best of my knowledge