-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gmp] build failure which prevents [cgal] from also building #15956
Comments
according to #15957 gmp builds fine on osx and linux if you have the required system tools installed |
I can build gmp fine on my Mac now. |
Do you install "yasm-tool"? |
I had the same issue, could fix it by manually installing yasm-tool:x86-windows and vs-yasm:x86-windows as the output stated:
Is it possible to make x64-gmp dependent on yasm x86 so that vcpkg installs it automatically? |
no currently not. |
Had the same issue on MacOS. I installed the
Then, there is an issue with
|
If there is not |
Yes, apparently I didn't know how |
I confirm, on ubuntu Unfortunately one package later,
|
means you need to install |
thx, that helped, it moved the needle a bit, but still fails; this time I managed to figure it out by myself: after installing |
Go ahead and use HEAD of vcpkg, so add all the dependencies required as a result of microsoft/vcpkg#15956.
Even with the prerequisites installed, things are still screwy. You may be able to install the package, but
This also happens with GitHub actions: https://github.com/acgetchell/CDT-plusplus/runs/1932831244?check_suite_focus=true#step:4:18 But again, not when I pin the version: https://travis-ci.com/github/acgetchell/CDT-plusplus/jobs/484441192#L479 |
Strange things happen with vcpkg(master), such as installed packages not being seen. Pinning to a particular version fixes the problem elsewhere. microsoft/vcpkg#15956 (comment)
@acgetchell problem should be fixed on master. Sorry for the troubles. #16293 |
Thanks, I can confirm that vcpkg.cmake was fixed: https://github.com/acgetchell/CDT-plusplus/actions/runs/582487745 Also, installing AppVeyor (and many other systems) use chocolatey for their package manager, and I don't see a package for Have folks built this on Windows, and if so, how did you get the prerequisites installed? |
you should not need any external dependency on windows. Can you point to a failed windows installation ci log? |
On windows I needed to use:
which not only that should be done automatically, but it is counterintuitieve as I use x64 |
Check that AppVeyor can still build cgal to verify that microsoft/vcpkg#15956 is resolved.
The new version of CGAL builds with GMP rather than MPIR, but GMP won't install if MPIR is present. Hopefully resolves microsoft/vcpkg#15956
CGAL requires GMP which on Windows requires yasm-tool:x86-windows, even if you are using x64-windows. And vcpkg does not automatically know of this dependency. Thanks to microsoft/vcpkg#15956 (comment)
Thank you! I can confirm that I can also confirm that with all of the guidance folks posted here, macOS/Linux prerequisites:
Windows prerequisites:
Thanks again to all of the contributors in this thread! |
Describe updated setup and installation. The CGAL formula changed from using MPIR to GMP, which requires new prerequisites, which folks kindly resolved in microsoft/vcpkg#15956. Also, mention Docker image for those wanting to use it. Finally, credit companies providing commercial-grade services to this project. Closes microsoft/vcpkg#15956
"vcpkg install --recurse yasm-tool:x86-windows" does not help me. I always get the error code 2 when I install gmp:x64-windows in visual studio console. I have also tried installing gmp:x64-windows-static or even x86-windows-static, which give me the same error messages. By the way, I once tried installation of mpir which worked successfully, but then cgal still would not install. It seems to me that mpir was not recognized as a replacement for gmp and I don't know how to configure it if possible. Currently I have removed mpir from my installation. If I can get help about how to install cgal with mpir, I would be happy, since installing mpir is not a problem for me. Any suggestion about what can I do? Thanks in advance! |
gmp no longer requires yasm since it was switched to use clang instead for compiling assembly files. So your issue with a current baseline is probably unrelated to this issue. |
Any suggestion about what to do? |
Open a new issue with the output and error logs? |
Thanks. I have opened a new issue at : [gmp] build failure that prevents installation of [cgal] in windows #33445 |
Host Environment
To Reproduce
Steps to reproduce the behavior:
./vcpkg remove mpir
./vcpkg install cgal
Failure logs
Additional context
The vcpkg port for
cgal
switched frommpir
togmp
, which caused #15881. Commit 7f400c4 is supposed to resolve this. However, aftermpir
is uninstalled,gmp
won't install, which causescgal
to fail.The text was updated successfully, but these errors were encountered: