Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[matplot++] <requires nodesoup and fftw3[threads]> #17416

Closed
SKNo opened this issue Apr 21, 2021 · 4 comments · Fixed by #17461 or #17552
Closed

[matplot++] <requires nodesoup and fftw3[threads]> #17416

SKNo opened this issue Apr 21, 2021 · 4 comments · Fixed by #17461 or #17552
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@SKNo
Copy link

SKNo commented Apr 21, 2021


Is your feature request related to a problem? Please describe.
I've built Matplot++ library without any problem (x64-windows and x64-windows-static). However I cannot build simple examples (linktime error).

Matplot++ requires nodesoup (nodesoup is available on https://github.com/olvb/nodesoup)

  • error LNK2019: unresolved external symbol "class std::vector<struct nodesoup::Point2D,class std::allocator<struct nodesoup ...

Matlab++ seems to require fftw3[threads] because of Cimg

  • Matplot++ requires Cimg and the Cimg built by vcpkg requires fftw3[threads], so vcpkg should build fftw3[threads] as a prerequisite for Cimg, or if possible Cimg should be built with installed version of fftw3. I had to rebuild fftw3 with threads (which forced me to rebuild other packages such as dlib).

Proposed solution
Just my thoughts :

  • Evidently add nodesoupe
  • If possible , building ftw3[threads] uniquely for Cimg or buildind Cimg with already installed version of fftw3 such as fftw3 or fftw3[openmp].

Describe alternatives you've considered
At this moment I would try binary packages of Matplotlib++ provided by author https://alandefreitas.github.io/matplotplusplus/.

Additional context
Thank you

@SKNo SKNo changed the title [matplot++] <requires nodesoupe and fftw3[threads]> [matplot++] <requires nodesoup and fftw3[threads]> Apr 21, 2021
@leha-bot
Copy link
Contributor

Yes, they are bundled into the main repo; I think that the right way is to unbundle it and package it into vcpkg (also there was CImg in repo)

@SKNo
Copy link
Author

SKNo commented Apr 22, 2021

@leha-bot @JackBoosY
I've double checked : vcpkg builds nodesoup, and copies it at subdirectory VcpkgDir\installed\x64-windows\debug\lib\Matplot++ like binary distribution by the author (I don't know why there) .... I had to add it manually for linking.

@JackBoosY
Copy link
Contributor

Confirmed.

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Apr 23, 2021
@ras0219-msft ras0219-msft reopened this Apr 23, 2021
@ras0219-msft
Copy link
Contributor

Reopened because fftw3[threads] may still not be solved

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
4 participants