Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[matplotplusplus] Install extra 3rd libraries #17461

Merged
merged 2 commits into from
Apr 23, 2021
Merged

[matplotplusplus] Install extra 3rd libraries #17461

merged 2 commits into from
Apr 23, 2021

Conversation

JackBoosY
Copy link
Contributor

Install internal extra 3rd library nodesoup since it's not added in vcpkg.

Fixes #17416.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Apr 23, 2021
@JackBoosY
Copy link
Contributor Author

@SKNo Can you please test this PR?

Thanks.

@SKNo
Copy link

SKNo commented Apr 23, 2021

@JackBoosY @NancyLi1013
Works great
Thank you

@SKNo Can you please test this PR?

Thanks.

@ras0219-msft ras0219-msft merged commit 529efa7 into microsoft:master Apr 23, 2021
@JackBoosY JackBoosY deleted the dev/jack/17416 branch April 24, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 Awaiting requested review from NancyLi1013

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[matplot++] <requires nodesoup and fftw3[threads]>
4 participants
@JackBoosY @SKNo @ras0219-msft @NancyLi1013