Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libredwg] Build error on x64-windows #36889

Closed
HorrZzz opened this issue Feb 21, 2024 · 1 comment · Fixed by #36912
Closed

[libredwg] Build error on x64-windows #36889

HorrZzz opened this issue Feb 21, 2024 · 1 comment · Fixed by #36912
Assignees
@MonicaLiu0311
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@HorrZzz
Copy link

HorrZzz commented Feb 21, 2024

Package: libredwg[core,tools]:x64-windows@0.12.5.5178#1

Host Environment

  • Host: x64-windows
  • Compiler: MSVC 19.29.30151.0
  • vcpkg-tool version: 2024-01-11-710a3116bbd615864eef5f9010af178034cb9b44
    vcpkg-scripts version: 13bde2f 2024-02-17 (4 days ago)

To Reproduce

vcpkg install libredwg[tools]
Failure logs

-- Downloading https://github.com/LibreDWG/libredwg/archive/0.12.5.5178.tar.gz -> LibreDWG-libredwg-0.12.5.5178.tar.gz...
[DEBUG] To include the environment variables in debug output, pass --debug-env
[DEBUG] Trying to load bundleconfig from C:\SelfApps\vcpkg\vcpkg\vcpkg-bundle.json
[DEBUG] Failed to open: C:\SelfApps\vcpkg\vcpkg\vcpkg-bundle.json
[DEBUG] Bundle config: readonly=false, usegitregistry=false, embeddedsha=nullopt, deployment=Git, vsversion=nullopt
[DEBUG] Metrics enabled.
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
[DEBUG] Feature flag 'dependencygraph' unset
Downloading https://github.com/LibreDWG/libredwg/archive/0.12.5.5178.tar.gz
error: Failed to download from mirror set
error: https://github.com/LibreDWG/libredwg/archive/0.12.5.5178.tar.gz: failed: status code 404
[DEBUG] D:\a\_work\1\s\src\vcpkg\base\downloads.cpp(1029): 
[DEBUG] Time in subprocesses: 0us
[DEBUG] Time in parsing JSON: 3us
[DEBUG] Time in JSON reader: 0us
[DEBUG] Time in filesystem: 3763us
[DEBUG] Time in loading ports: 0us
[DEBUG] Exiting after 2 s (1971075us)

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:32 (message):
      
      Failed to download file with error: 1
      If you are using a proxy, please check your proxy setting. Possible causes are:
      
      1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable
         to `https://address:port`. This is not correct, because `https://` prefix
         claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr
         , etc..) is an HTTP proxy. Try setting `http://address:port` to both
         HTTP_PROXY and HTTPS_PROXY instead.
      
      2. If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings
         set by your proxy software. See https://github.com/microsoft/vcpkg-tool/pull/77
         The value set by your proxy might be wrong, or have same `https://` prefix issue.
      
      3. Your proxy's remote server is out of service.
      
      If you've tried directly download the link, and believe this is not a temporary
      download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues
      to report this upstream download server failure.
      

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:270 (z_vcpkg_download_distfile_show_proxy_and_fail)
  scripts/cmake/vcpkg_from_github.cmake:106 (vcpkg_download_distfile)
  ports/libredwg/portfile.cmake:1 (vcpkg_from_github)
  scripts/ports.cmake:170 (include)
@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Feb 22, 2024
@MonicaLiu0311 MonicaLiu0311 mentioned this issue Feb 22, 2024
Merged
7 tasks
@MonicaLiu0311
Copy link
Contributor

MonicaLiu0311 commented Feb 22, 2024 •
edited
Loading

Fixing by #36848 and #36912.

PR #30005 updated libredwg to 0.12.5.5178, but this is a pre-release version rather than an officially released version. It is unstable and may be removed by upstream, PR #36848 update libredwg to the release version 0.13.2 to fix the above issue.

vicroms pushed a commit that referenced this issue Feb 22, 2024
@MonicaLiu0311
[libredwg] Fix the usage error and cleanup patch (#36912)
72d66da 
Fixes #36889.

* Fix usage error:
```
C:\source\repos\CMakeUsage\CMakeUsage\CMakeUsage.cpp(2,10): error C1083: Cannot open include file: 'libredwg/dwg.h': No such file or directory 
```

* Cleanup redundant patches: `fix_arm64_build.patch`.

- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [ ] ~The "supports" clause reflects platforms that may be fixed by
this new version.~
- [ ] ~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~
- [ ] ~Any patches that are no longer applied are deleted from the
port's directory.~
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

All features are tested successfully in the following triplet:
```
x86-windows
x64-windows
x64-windows-static
```

The usage test passed on `x64-windows` (header files found):
```
libredwg provides CMake targets:

    find_package(unofficial-libredwg CONFIG REQUIRED)
    target_link_libraries(main unofficial::libredwg::libredwg)
```

---------

Co-authored-by: Monica <v-liumonica@microsoft.com>
TomKatom pushed a commit to TomKatom/vcpkg that referenced this issue Feb 23, 2024
@MonicaLiu0311 @TomKatom
[libredwg] Fix the usage error and cleanup patch (microsoft#36912)
d466f37 
Fixes microsoft#36889.

* Fix usage error:
```
C:\source\repos\CMakeUsage\CMakeUsage\CMakeUsage.cpp(2,10): error C1083: Cannot open include file: 'libredwg/dwg.h': No such file or directory 
```

* Cleanup redundant patches: `fix_arm64_build.patch`.

- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [ ] ~The "supports" clause reflects platforms that may be fixed by
this new version.~
- [ ] ~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~
- [ ] ~Any patches that are no longer applied are deleted from the
port's directory.~
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

All features are tested successfully in the following triplet:
```
x86-windows
x64-windows
x64-windows-static
```

The usage test passed on `x64-windows` (header files found):
```
libredwg provides CMake targets:

    find_package(unofficial-libredwg CONFIG REQUIRED)
    target_link_libraries(main unofficial::libredwg::libredwg)
```

---------

Co-authored-by: Monica <v-liumonica@microsoft.com>
Osyotr pushed a commit to Osyotr/vcpkg that referenced this issue Feb 26, 2024
@MonicaLiu0311 @Osyotr
[libredwg] Fix the usage error and cleanup patch (microsoft#36912)
a54f0f8 
Fixes microsoft#36889.

* Fix usage error:
```
C:\source\repos\CMakeUsage\CMakeUsage\CMakeUsage.cpp(2,10): error C1083: Cannot open include file: 'libredwg/dwg.h': No such file or directory 
```

* Cleanup redundant patches: `fix_arm64_build.patch`.

- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [ ] ~The "supports" clause reflects platforms that may be fixed by
this new version.~
- [ ] ~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~
- [ ] ~Any patches that are no longer applied are deleted from the
port's directory.~
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

All features are tested successfully in the following triplet:
```
x86-windows
x64-windows
x64-windows-static
```

The usage test passed on `x64-windows` (header files found):
```
libredwg provides CMake targets:

    find_package(unofficial-libredwg CONFIG REQUIRED)
    target_link_libraries(main unofficial::libredwg::libredwg)
```

---------

Co-authored-by: Monica <v-liumonica@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libredwg] Fix the usage error and cleanup patch MonicaLiu0311/vcpkg
2 participants
@HorrZzz @MonicaLiu0311