-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libredwg] Add new port #30005
Merged
Merged
[libredwg] Add new port #30005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msclock
force-pushed
the
new_port_libredwg
branch
6 times, most recently
from
March 3, 2023 18:56
26d0d73
to
bfa07fd
Compare
@Adela0814 requires approval |
Osyotr
reviewed
Mar 4, 2023
msclock
force-pushed
the
new_port_libredwg
branch
2 times, most recently
from
March 4, 2023 13:45
1878ceb
to
daab7ca
Compare
dg0yt
suggested changes
Mar 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the PR. I took a moment to collect some comments.
msclock
force-pushed
the
new_port_libredwg
branch
3 times, most recently
from
March 4, 2023 22:19
1c09ec4
to
c62a49b
Compare
Adela0814
added
the
category:new-port
The issue is requesting a new library to be added; consider making a PR!
label
Mar 6, 2023
Adela0814
suggested changes
Mar 6, 2023
msclock
force-pushed
the
new_port_libredwg
branch
from
March 6, 2023 03:43
c62a49b
to
8594484
Compare
Because some formating changes, and requre reiview agiain. @Adela0814 |
Adela0814
approved these changes
Mar 6, 2023
Adela0814
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:author-response
labels
Mar 6, 2023
dan-shaw
reviewed
Mar 6, 2023
dan-shaw
added
the
depends:different-pr
This PR or Issue depends on a PR which has been filed
label
Mar 6, 2023
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:new-port
The issue is requesting a new library to be added; consider making a PR!
depends:different-pr
This PR or Issue depends on a PR which has been filed
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29980
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.