Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libredwg] Add new port #30005

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

msclock
Copy link
Contributor

@msclock msclock commented Mar 3, 2023

Fixes #29980

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@msclock
Copy link
Contributor Author

msclock commented Mar 3, 2023

@Adela0814 requires approval

ports/libredwg/usage Outdated Show resolved Hide resolved
@msclock msclock force-pushed the new_port_libredwg branch 2 times, most recently from 1878ceb to daab7ca Compare March 4, 2023 13:45
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the PR. I took a moment to collect some comments.

ports/libredwg/build_and_install_fix.patch Outdated Show resolved Hide resolved
ports/libredwg/build_and_install_fix.patch Outdated Show resolved Hide resolved
ports/libredwg/build_and_install_fix.patch Outdated Show resolved Hide resolved
ports/libredwg/build_and_install_fix.patch Outdated Show resolved Hide resolved
ports/libredwg/portfile.cmake Outdated Show resolved Hide resolved
ports/libredwg/portfile.cmake Outdated Show resolved Hide resolved
ports/libredwg/portfile.cmake Outdated Show resolved Hide resolved
ports/libredwg/portfile.cmake Outdated Show resolved Hide resolved
ports/libredwg/usage Outdated Show resolved Hide resolved
ports/libredwg/usage Outdated Show resolved Hide resolved
@msclock msclock force-pushed the new_port_libredwg branch 3 times, most recently from 1c09ec4 to c62a49b Compare March 4, 2023 22:19
@msclock msclock requested review from Osyotr and dg0yt and removed request for Osyotr and dg0yt March 4, 2023 22:26
@Adela0814 Adela0814 self-assigned this Mar 6, 2023
@Adela0814 Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 6, 2023
ports/libredwg/portfile.cmake Outdated Show resolved Hide resolved
ports/libredwg/portfile.cmake Outdated Show resolved Hide resolved
ports/libredwg/portfile.cmake Outdated Show resolved Hide resolved
@msclock msclock requested review from Adela0814 and removed request for dg0yt March 6, 2023 03:52
@msclock
Copy link
Contributor Author

msclock commented Mar 6, 2023

Because some formating changes, and requre reiview agiain. @Adela0814

@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 6, 2023
@dan-shaw dan-shaw added the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 6, 2023
@dan-shaw dan-shaw merged commit 4e57712 into microsoft:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! depends:different-pr This PR or Issue depends on a PR which has been filed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] <libredwg>
5 participants