-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more recent version of libnice/GLib #5798
Comments
@colatkinson, thanks for summit the PR! |
Sorry to closed it by mistakes, Glib still doesn't upgrade, reopen it. |
@PhoebeHui I actually totally forgot I included GLib as part of this issue. I'll make a PR to bring it up to date in the next couple days so that this can finally be closed. |
So I've been attempting this, but have run into a few issues. For one, more recent versions of GLib have actually dropped the Visual Studio projects, as a part of their conversion to full usage of meson. The last version that includes these projects is 2.57.1, and this is thus the upper limit on what can be built using current methods. The difficulty extends beyond just extracting the source lists, however. Meson has its own configuration directives, such as I think the best solution would be to use the native meson build configuration of GLib, as it could probably decrease the amount of downstream patching needed for a number of GNOME projects. I messed around with it a bit, but couldn't figure out how to get meson to recognize the build deps pulled in from vcpkg. There are a couple other packages that use meson builds (fribidi and libepoxy, specifically), but neither has any external dependencies. If anyone has any views/advice on how to continue, please let me know. |
@colatkinson windows? of course the code is not quite beautiful dependencies are found |
@voskrese Yes, this is on Windows. Unfortunately, I believe that meson depends on the pkgconfig binary existing, which I don't believe it does as a part of vcpkg? Please correct me if I'm wrong, as that would make the problem far simpler. If it does exist, meson can't find it.
I've actually made a bit of progress by patching the |
Currently, the packaged versions of GLib and libnice are fairly out of date (glib==2.52.3, which was released in June 2017, and libnice==0.1.13, released in April 2015).
Is there a specific blocker as to why these versions are being used (e.g. some cascading dependency incompatibilities)? If not, I would be willing to attempt to update the packages, but I wanted to make sure doing so wouldn't inadvertently break things.
On a somewhat-related note, it appears that GLib is being built using a CMake build wrapper, instead of the
vcpkg
wrapper around Meson. Is there a reason for this? It seems like converting it could decrease maintenance overhead in the future.The text was updated successfully, but these errors were encountered: