New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] create pkg-config files #7129
Conversation
)) windows? |
I'm not sure if pkgconfig files are needed on windows, removing 3 lines here - vcpkg/scripts/cmake/vcpkg_pkgconfig.cmake Line 49 in 8a79337
|
meson works tight with pkgconfig |
ok, removed windows check - should work on windows too now |
@isanych Игорь, верните, пока vcpkg для виндовс не работает с pkgconfig. я спросил про запас, так сказать на будущее там плотно meson + pkgconfig связаны |
Closes #7162 |
@isanych, Is work still being done for this PR? Could you please resolve the conflicts? |
@PhoebeHui, ok I'll give it another go - last time build server was failing without obvious reason for me - so I'm just using own branch, but it would be nice to have less differences with upstream |
/azp run |
Commenter does not have sufficient privileges for PR 7129 in repo microsoft/vcpkg |
@isanych, I test the changes locally, and it failed with following failure, it looks a vcpkg bug in this change: PS F:\vcpkg\7129\vcpkg> ./vcpkg install libmediainfo
|
@PhoebeHui, thank you - I see the issue, I'm passing description (beside other variables) to cmake - |
If you truly want a full-rebuild modifying the |
@cbezault full rebuild helped thank you |
The failures doesn't related to this change, @isanych, could you also update the Version in CONTROL file in related ports? I will ask team member help to do feature review. |
@isanych, could you please resolve the conflicts? @strega-nil, could you help review this feature? |
# Conflicts: # ports/harfbuzz/CONTROL # ports/harfbuzz/portfile.cmake # toolsrc/src/vcpkg-test/strings.cpp
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
# Conflicts: # ports/icu/CONTROL # toolsrc/src/vcpkg/build.cpp
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
When I was building non vcpkg Qt using vcpkg dependencies, I was struggling until I created pkg-config files for vcpkg libs, so I decided to automate this process. Change should not affect cmake usage of vcpkg, but help to use vcpkg created libs as non cmake dependencies. As a side effect port version could be used in cmake files, one place less to change during version change process.
vcpkg_pkgconfig
cmake function generates pkgconfig file, next cmake variables added:PORT_FULL_VERSION
- Version from CONTROL filePORT_VERSION
-PORT_FULL_VERSION
without vcpkg version suffixPORT_CMAKE_VERSION
- cmake compatible version, 4 version components max, numbers onlyPORT_DESCRIPTION
- Description from CONTROL filePORT_HOMEPAGE
- Homepage from CONTROL filePORT_DEPENDENCIES
- list of port dependenciesCloses #7162