Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libnice to 0.1.15 #5811

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Conversation

colatkinson
Copy link
Contributor

Related to #5798

I tried getting the build to just use Meson natively, but the documentation was somewhat sparse. So, I've just updated the existing CMake wrapper. I also figured updating GLib would be more onerous, and far more likely to break things.

I also spun up a quick test project to make sure there weren't any missing public headers or objects, which you can check out here.

Let me know if you have any changes you'd like w.r.t. style or functionality.

@msftclas
Copy link

msftclas commented Mar 26, 2019

CLA assistant check
All CLA requirements met.

@@ -1,4 +1,4 @@
Source: libnice
Version: 0.1.13-2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this version number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yeah I'll change it later tonight.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes made

@Rastaban Rastaban self-assigned this Mar 26, 2019
@Rastaban
Copy link
Contributor

Awesome, Thanks!

@Rastaban Rastaban merged commit 23932c3 into microsoft:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants