Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unixODBC] Add new port #10057

Merged
merged 2 commits into from
Mar 13, 2020
Merged

[unixODBC] Add new port #10057

merged 2 commits into from
Mar 13, 2020

Conversation

kreuzerkrieg
Copy link
Contributor

@kreuzerkrieg kreuzerkrieg commented Feb 13, 2020 •
edited
Loading

  • What does your PR fix?
    Add unixODBC port
  • Which triplets are supported/not supported?
    No Win/UWP
  • Have you updated the CI baseline?
    Yes
  • Does your PR follow the maintainer guide?
    Yes

@ras0219-msft
Copy link
Contributor

/azp run

PhoebeHui
PhoebeHui approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

I will help rerun after the CI baseline issue fix.

@PhoebeHui
Copy link
Contributor

/azp run

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Feb 20, 2020
This was referenced Feb 21, 2020
Closed
Open
@kreuzerkrieg
Copy link
Contributor Author

Anything prevents this PR from being merged?

@strega-nil strega-nil self-assigned this Mar 11, 2020
@strega-nil
Copy link
Contributor

Alright, we're currently waiting on the qt tools to be fixed in the CI, then we'll merge :)

@PhoebeHui
Copy link
Contributor

After rerun, the CI test pass.

@strega-nil
Copy link
Contributor

Awesome, thanks @kreuzerkrieg for all this work you're doing!

@strega-nil strega-nil merged commit cd0ea13 into microsoft:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@strega-nil strega-nil

@PhoebeHui PhoebeHui

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kreuzerkrieg @ras0219-msft @PhoebeHui @strega-nil