Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[raylib] Update to 2.6.0 #10068

Merged
merged 2 commits into from
Mar 13, 2020
Merged

[raylib] Update to 2.6.0 #10068

merged 2 commits into from
Mar 13, 2020

Conversation

NancyLi1013
Copy link
Contributor

Update raylib to the latest released version 2.6.0.

Update copyright and some deprecated functions.

Related issue #9830

Note: Feature have passed with the following triplets:

  • x86-windows
  • x64-windows

@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label Feb 14, 2020
PhoebeHui
PhoebeHui approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NancyLi1013
Copy link
Contributor Author

/azp run

1 similar comment
@PhoebeHui
Copy link
Contributor

/azp run

@PhoebeHui PhoebeHui marked this pull request as ready for review February 20, 2020 00:59
@PhoebeHui
Copy link
Contributor

/azp run

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Feb 20, 2020
@valenotary
Copy link

Has this been merged yet?

@PhoebeHui
Copy link
Contributor

Not yet, @strega-nil, could you please review and merge this PR?

strega-nil
strega-nil reviewed Mar 5, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I wonder if you know why that thing is commented out?

ports/raylib/CONTROL Outdated Show resolved Hide resolved
@PhoebeHui
Copy link
Contributor

After rerun, the CI test pass.

@strega-nil
Copy link
Contributor

Awesome, thanks @NancyLi1013 :D

@strega-nil strega-nil merged commit fea4df8 into microsoft:master Mar 13, 2020
@NancyLi1013 NancyLi1013 deleted the dev/NancyLi/9830-update-raylib branch March 13, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@strega-nil strega-nil

@PhoebeHui PhoebeHui

Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NancyLi1013 @PhoebeHui @valenotary @strega-nil