[qt-advanced-docking-system] updated qt-advanced-docking-system to 3.2.1

[stijnherfst]

Updates the library to the newest release which fixes several bugs and adds features.

[stijnherfst]

I'm not sure why only the Linux version is saying that there is no CMakeLists.txt present while the Windows one can find it fine and I made no big changes to the project.

[NancyLi1013]

Hi @stijnherfst

Can you install this port on Linux platform successfully on your local? I try to repro this on my local but it failed due to qt5-base,

[stijnherfst]

It seems like this might be an issue on your end with qt5-base indeed not compiling properly.

[NancyLi1013]

We have been working on the regreassions on Linux about libhdfs3 ,osg-qt and try to fix them now.
But I'm not sure if this PR is realted to these regressions.
Once fixed, I will rerun this PR.
Let's wait for the new CI test results.

[NancyLi1013]

/azp run

[NancyLi1013]

The regressions on Linux like this:

CMake Error at /ci/myagent/_work/1/s/installed/x64-linux/share/cmake/Qt5Gui/Qt5GuiConfig.cmake:15 (message):
  The imported target "Qt5::Gui" references the file

     "/ci/myagent/_work/3/s/installed/x64-linux/lib/libEGL.so"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "/ci/myagent/_work/1/s/installed/x64-linux/share/cmake/Qt5Gui/Qt5GuiConfigExtras.cmake"

  but not all the files it references.

Since this error is related to qt5-base.
So currently, we might add qt-advanced-docking-system:x64-linux=fail to ci.baseline.txt.

[BogdanW3]

Just to note, building under Linux works for me now so I think the update is ok.
Homepage line is now included too.

[stijnherfst]

This issue should automatically be resolved at some point in the future and thus I think merging it should be fine.

[stijnherfst]

So is this going to be merged? The problem with compilation on Linux seems to be due to another package that this depends on having issues and is not related to this package then. The previous version of this package should then also fail to build because one of its dependencies fails and thus this PR doesn't regress anything.

[dan-shaw]

The changes look good to me. Right now, none of the Qt packages are getting downloaded on our CI for some reason. We're looking into it and trying to get it resolved ASAP. After that, we can merge this. I will tag this 'reviewed' so we don't forget about it.

[dan-shaw]

@stijnherfst Can you resolve the conflict? we just fixed the Qt problem in our CI

[NancyLi1013]

@stijnherfst
Thanks for your update.
LGTM now. Once the regression about qt5-tools on Linux is fixed, I will tag this as 'Reviewed'.

[stijnherfst]

That's an issue on your end, right?

[dan-shaw]

/azp run

[ras0219-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ras0219-msft]

LGTM, thanks for the PR!