[pcl] Move VTK to an optional feature

[here-mikelley]

Describe the pull request

• What does your PR fix? Fixes issue #

This doesn't fix an issue.

• Which triplets are supported/not supported? Have you updated the CI baseline?

All triplets should be supported. Making VTK optional also allows pcl to be compiled as a dynamic library under Linux.

• Does your PR follow the maintainer guide?

Yes

[msftclas]

All CLA requirements met.

[JackBoosY]

/azp run

[JackBoosY]

@here-mikelley Does this issue ready to review?

[here-mikelley]

@JackBoosY I believe it is. Please review.

[dan-shaw]

@here-mikelley Why does VTK need to be an optional feature? You can install pcl without VTK using vcpkg install pcl[core]

[here-mikelley]

@here-mikelley Why does VTK need to be an optional feature? You can install pcl without VTK using vcpkg install pcl[core]

I must be misunderstanding Build-Depends and feature lists. Isn't Build-Depends a list of required dependencies? I thought that the feature list disabled default features and enabled optional features. I interpret pcl[core] to mean that all build dependencies specified in Build-Depends are required and built.

[here-mikelley]

@dan-shaw , I just tried your suggestion and it still installs vtk:

PS /Users/mikelley/vcpkg> ./vcpkg/vcpkg install pcl[core]:x64-osx
Computing installation plan...
The following packages will be built and installed:
  * boost-asio[core]:x64-osx
  * boost-coroutine[core]:x64-osx
  * boost-signals2[core]:x64-osx
  * flann[core]:x64-osx
  * openssl[core]:x64-osx
    pcl[core]:x64-osx
  * vtk[core]:x64-osx
Additional packages (*) will be modified to complete this operation.

[NancyLi1013]

@here-mikelley
Could you please resolve the conflicts?

[here-mikelley]

@here-mikelley
Could you please resolve the conflicts?

It looks as though VTK was forced to be OFF in the latest code on master. My commit moved VTK to a feature that can be turned off/on, so I'm not sure how to resolve this conflict. We should revisit this change once VTK is enabled again.

[NancyLi1013]

Hi @here-mikelley

Feature vtk build failed on x86-windows:

F:\10449\vcpkg\buildtrees\pcl\src\pcl-1.9.1-f2ec88a858\io\src\vtk_lib_io.cpp(369): error C2664: 'int vtkCellArray::GetNextCell(vtkIdList *)': cannot convert argument 2 from 'vtkIdType *' to 'const vtkIdType *&'

Could you please try to look into it?

[NancyLi1013]

Hi @here-mikelley
Is work still being done for this PR?

[here-mikelley]

VTK is currently disabled for pcl as shown below:

vcpkg/ports/pcl/portfile.cmake

Line 49 in 7960648

-DWITH_VTK=OFF # disabled due to API changes in 9.0

I've paused work on this until it's enabled again.

[NancyLi1013]

Sorry for the late reply.
Seems you have removed this line in this PR.

-DWITH_VTK=OFF # disabled due to API changes in 9.0

[BillyONeal]

Manually tested:

• pcl[core]:x86-windows (also checked that it did not install vtk)
• pcl[core,vtk]:x86-windows
• pcl[core]:x86-windows-static
• pcl[core,vtk]:x86-windows-static
• pcl[core]:x64-osx (also checked that it did not install vtk)
• pcl[core,vtk]:x64-osx

[BillyONeal]

Thanks for your contribution!