-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Fix [boost] find_package for MSVC2013 / v120 #10670
Merged
strega-nil
merged 3 commits into
microsoft:master
from
ManuelKugelmann:ManuelKugelmann-patch-boost-find_package_MSVC2013-v120-2
Aug 1, 2020
Merged
[vcpkg] Fix [boost] find_package for MSVC2013 / v120 #10670
strega-nil
merged 3 commits into
microsoft:master
from
ManuelKugelmann:ManuelKugelmann-patch-boost-find_package_MSVC2013-v120-2
Aug 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added conditional set(Boost_COMPILER "-vc120") to vcpkg.cmake
dan-shaw
reviewed
Jun 12, 2020
dan-shaw
approved these changes
Jun 12, 2020
yes |
@dan-shaw @PhoebeHui Ready to merge? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
What's going on with all these port failures? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
hellozee
pushed a commit
to hellozee/vcpkg
that referenced
this pull request
Sep 11, 2020
* Fix [boost] find_package for MSVC2013 / v120 added conditional set(Boost_COMPILER "-vc120") to vcpkg.cmake * fixed spacing * fixed spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
added conditional set(Boost_COMPILER "-vc120") to vcpkg.cmake
What does your PR fix?
Fixes issue [boost] find package failure with MSVC 2013 / v120 #10669
Does your PR follow the maintainer guide?
Yes