Fix [boost] MSVC 2013 v120 Build #10645
Conversation
only v140 / vc140 was expected, added handling of v120 / vc120
|
What is going on with the PR Test? My changes obviously only affect MSVC 2013 / v120 (and that in a positive way). Is there any way to see the result of the merge that is tested? Something must be wrong there or in the PR test ? |
|
@ManuelKugelmann, thanks for the PR! PR #10660 should adress the CI testing issue. |
added conditional set(Boost_COMPILER "-vc120") to vcpkg.cmake
do not know how to do it for real and have no idea what to google for to learn it ...
|
|
JackBoosY
added
the
category:port-bug
|
Hi @ManuelKugelmann , thanks for this PR! Thanks. |
|
@JackBoosY unfortunately I do not know how to conditionally exclude python from the dependencies list in the CONTROL file - any hints? |
|
@JackBoosY ah, many thanks. Somehow my google-foo failed to get me there on multiple tries ... |
|
Friendly ping to @ManuelKugelmann on whether you're still looking into this |
…t-find_package_MSVC2013-v120-2 Manuel kugelmann patch boost find package msvc2013 v120 2
…t-MSVC2013-v120 Manuel kugelmann patch boost msvc2013 v120
|
@ras0219-msft Will look into it right now |
|
@PhoebeHui @ras0219 Done? |
# Conflicts: # ports/boost/CONTROL # scripts/buildsystems/vcpkg.cmake
|
Thanks for your contribution! |
Describe the pull request
In
boost-modular-build.cmakeonly "v140" / "vc140" was expected,.Added handling of "v120" / "vc120"
What does your PR fix?
Fixes issue
[boost] build failure with MSVC 2013 / v120[boost] build failure with MSVC 2013 / v120 #10643Which triplets are supported/not supported? Have you updated the CI baseline?
Should not affect other triplets
Does your PR follow the maintainer guide?
Yes