Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[glib] Update the usage of string(TOUPPER ...) #10856

Merged
merged 2 commits into from
May 8, 2020
Merged

[glib] Update the usage of string(TOUPPER ...) #10856

merged 2 commits into from
May 8, 2020

Conversation

NancyLi1013
Copy link
Contributor

Update string(TOUPPER UPPER_CONFIG "${CMAKE_BUILD_TYPE}") as
string("${CMAKE_BUILD_TYPE}" TOUPPER UPPER_CONFIG).

Related issue #10853

Note: Feature has been passed with the following triplets:

  • x86-windows
  • x64-windows

Failed on triplets:

  • x64-windows-static(Only support dynamic build)
  • x64-linux(Failed on master branch)

@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label Apr 16, 2020
@NancyLi1013 NancyLi1013 marked this pull request as ready for review April 21, 2020 09:31
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Apr 29, 2020
@strega-nil
Copy link
Contributor

Any idea what's going on with libnice and cairo?

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil added waiting for response and removed info:reviewed Pull Request changes follow basic guidelines labels May 7, 2020
@NancyLi1013
Copy link
Contributor Author

@strega-nil
It seems all checks have passed on CI.

@strega-nil
Copy link
Contributor

Cool, thanks @NancyLi1013 :)

@strega-nil strega-nil merged commit 6c0d8bd into microsoft:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangL LilyWangL LilyWangL approved these changes

Assignees

@LilyWangL LilyWangL

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NancyLi1013 @strega-nil @LilyWangL