Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boost] update to 1.73.0 #11221

Merged
merged 15 commits into from
May 13, 2020
Merged

[boost] update to 1.73.0 #11221

merged 15 commits into from
May 13, 2020

Conversation

yurybura
Copy link
Contributor

@yurybura yurybura commented May 7, 2020 •
edited

Updates Boost to 1.73.0.
Release Notes: https://www.boost.org/users/history/version_1_73_0.html

Fixes #11147
Fixes #11035
Fixes #3495

@yurybura
Copy link
Contributor Author

yurybura commented May 7, 2020

CI machines don't like my PRs)
Dear @BillyONeal please have a look.
I've just removed boost-disjoint-sets port.
Thank you!

@BillyONeal
Copy link
Member

There are still ports that list boost-disjoint-sets as a dependency, so vcpkg is unable to proceed.

@yurybura
Copy link
Contributor Author

yurybura commented May 8, 2020 •
edited

There are still ports that list boost-disjoint-sets as a dependency, so vcpkg is unable to proceed.

Thank you for help. I didn't catch this from the original error message..

@PhoebeHui
Copy link
Contributor

https://github.com/microsoft/vcpkg/tree/master/ports/nowide should be removed when this PR merged.

PhoebeHui
PhoebeHui approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you as always!

@yurybura yurybura marked this pull request as ready for review May 11, 2020 05:34
@PhoebeHui
Copy link
Contributor

The CI test pass! thanks for the quick updates!

@yurybura
[boost-modular-build-helper] move port-specific b2 options to the fil…
60423fa 
…e `<port_dir>/b2-options.cmake`

[boost-python] support Python2 (fixes #3495)
@yurybura
Copy link
Contributor Author

yurybura commented May 11, 2020 •
edited

The CI test pass! thanks for the quick updates!

I hope the vcpkg's team could review and merge this PR quickly too)

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

Alright, awesome, thanks @yurybura :D

@strega-nil strega-nil merged commit 24e8be5 into microsoft:master May 13, 2020
@janisozaur janisozaur mentioned this pull request May 17, 2020
Closed
@PhoebeHui PhoebeHui mentioned this pull request Jun 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@dan-shaw dan-shaw dan-shaw approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@strega-nil strega-nil

@PhoebeHui PhoebeHui

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@yurybura @BillyONeal @PhoebeHui @strega-nil @dan-shaw