Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg/scripts/meson] add cross file and some minor corrections #11543

Closed
wants to merge 5 commits into from
Closed

[vcpkg/scripts/meson] add cross file and some minor corrections #11543

wants to merge 5 commits into from

Conversation

Neumann-A
Copy link
Contributor

add cross file. Use same cmake prefix has vcpkg cmake. Set debug to true or false

closes #11230
(requires mesonbuild/meson#7190 to correctly work)

hmm should I set the crossfile in the triplet instead? any opinions about that?

@vlj
Copy link
Contributor

vlj commented May 24, 2020

Do you know how to add meson to the linux/osx azure image ?

@Neumann-A
Copy link
Contributor Author

probably should set _vfa_SUPPORTED to on for meson in vcpkg_find_acquire_program.

@Neumann-A
[vcpkg/scripts/acquire_program] download meson on !windows
820a1b2
@Neumann-A
[vcpkg/scripts/meson] -move crossfile definition into triplet.
6b0e8f0 
- remove some unnecssary spaces
- remove unnecessary prefix definition from pkg-config call
(since *.pc files should have been made relocatable with vcpkg_fixup_pkgconfig)
@PhoebeHui PhoebeHui added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed requires:discussion labels May 26, 2020
@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui
Copy link
Contributor

The failures in boost with arm64 should adress by #11545

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY requested a review from dan-shaw June 2, 2020 08:28
@vlj
Copy link
Contributor

vlj commented Jun 5, 2020

What is the status of this pr ?

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jun 8, 2020
dan-shaw
dan-shaw reviewed Jun 12, 2020
View reviewed changes
scripts/toolchains/meson.windows.arm64.crossfile
@@ -0,0 +1,21 @@
[binaries]
Copy link
Contributor

@dan-shaw dan-shaw Jun 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to autogenerate this file from the toolchain?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably Yes. Needs to be done anyway since vcpkg_configure_make also requires that information to correctly set all build flags.

We need some kind of vcpkg_determine_compile_settings_from_cmake or similar to generate the required information for vcpkg_configure_make and vcpkg_configure_meson and maybe other not CMake related ports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also meson tries to do it the other way around e.g. have a meson crossfile and generate a cmake toolchain out of it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should figure out how to autogenerate this file before merging this. Otherwise, we may have too many files to maintain.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ras0219-msft do you have some suggestions?

Copy link
Contributor

@ras0219-msft ras0219-msft Jul 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing places where we already do this kind of thing are in the boost helpers and openssl-unix ports:

https://github.com/microsoft/vcpkg/blob/master/ports/boost-modular-build-helper/boost-modular-build.cmake
https://github.com/microsoft/vcpkg/blob/master/ports/openssl-unix/CMakeLists.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice those two scripts should be generalized.
A lot of that stuff is actually also required for vcpkg_configure_make and vcpkg_configure_qmake apart form vcpkg_configure_meson

@JackBoosY JackBoosY added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly and removed category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed labels Jun 12, 2020
@Neumann-A Neumann-A mentioned this pull request Jul 2, 2020
Closed
@Neumann-A Neumann-A marked this pull request as draft July 6, 2020 16:07
@Neumann-A
Copy link
Contributor Author

Back to draft until somebody generalized #11543 (comment).
The required PRs on the meson side have been merged so with the next meson release we should finish this one here.

@Neumann-A
Copy link
Contributor Author

(although meson does not allow to pass a cmake toolchain to the find_dep calls so we probably want to always use pkgconfig if possible

@strega-nil strega-nil added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jul 31, 2020
@Neumann-A Neumann-A closed this Aug 16, 2020
@Neumann-A Neumann-A deleted the fix_script_details branch September 18, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms left review comments

@dan-shaw dan-shaw dan-shaw approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vcpkg_configure_meson does not support cross-compilation
8 participants
@Neumann-A @vlj @PhoebeHui @JackBoosY @vicroms @ras0219-msft @dan-shaw @strega-nil