Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Move CI cleaning back out of the 'ci' command into a separate command to restore cross-compilation preinstalls. #11545

Merged
merged 1 commit into from
May 28, 2020
Merged

[vcpkg] Move CI cleaning back out of the 'ci' command into a separate command to restore cross-compilation preinstalls. #11545

merged 1 commit into from
May 28, 2020

Conversation

BillyONeal
Copy link
Member

No description provided.

@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels May 24, 2020
@BillyONeal BillyONeal requested a review from PhoebeHui May 24, 2020 05:40
This was referenced May 24, 2020
Merged
Closed
Merged
@PhoebeHui PhoebeHui mentioned this pull request May 26, 2020
Merged
@NancyLi1013 NancyLi1013 mentioned this pull request May 26, 2020
Closed
@LilyWangL
Copy link
Contributor

Please remove the following command in scripts/ci.baseline.txt. Thanks.

protobuf:x64-uwp=ignore
protobuf:arm64-windows=ignore
protobuf:arm-uwp=ignore

@NancyLi1013
Copy link
Contributor

@BillyONeal

Could you help also add this for ignition-msgs5?
#11538 (comment)

@BillyONeal
Copy link
Member Author

@NancyLi1013 This PR appears unrelated to that one other than that this one should merge first because it restores a workaround in CI upon which the other one depends.

@BillyONeal
[vcpkg] Move CI cleaning back out of the 'ci' command into a separate…
b1a7a37 
… command to restore cross-compilation preinstalls.
@NancyLi1013
Copy link
Contributor

@BillyONeal Thanks for your clarification. Seems the CI in that PR has passed now.

@Cheney-W Cheney-W mentioned this pull request May 27, 2020
Merged
@JackBoosY
Copy link
Contributor

Related: #11502.

@PhoebeHui
Copy link
Contributor

@BillyONeal, does this changes test by CI system actually?

@BillyONeal
Copy link
Member Author

@PhoebeHui This change just puts a workaround back in place that I accidentally removed in f2c46e7

I have been testing the change as part of the effort to refresh the workers, which does a complete rebuild. ( #11365 ) (There are a few failures there, but none related to this)

@PhoebeHui PhoebeHui mentioned this pull request May 27, 2020
Closed
@BillyONeal BillyONeal merged commit d9b4acf into microsoft:master May 28, 2020
@BillyONeal BillyONeal deleted the preinstall_ci branch May 28, 2020 01:40
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@BillyONeal
[vcpkg] Move CI cleaning back out of the 'ci' command into a separate…
449a929 
… command to restore cross-compilation preinstalls. (microsoft#11545)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

@PhoebeHui PhoebeHui Awaiting requested review from PhoebeHui

Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

@dan-shaw dan-shaw

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@BillyONeal @LilyWangL @NancyLi1013 @JackBoosY @PhoebeHui @strega-nil @dan-shaw