Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cpputest] Move library to manual-link #11585

Merged
merged 2 commits into from
May 28, 2020
Merged

[cpputest] Move library to manual-link #11585

merged 2 commits into from
May 28, 2020

Conversation

JackBoosY
Copy link
Contributor

When using cpputest, we need to link the system library winmm.lib, which will cause the link error issue after vcpkg is integrated into the project:

2>CppUTest.lib(UtestPlatform.cpp.obj) : error LNK2001: unresolved external symbol __imp__fputs 
2>CppUTest.lib(UtestPlatform.cpp.obj) : error LNK2001: unresolved external symbol __imp___localtime64_s 
2>CppUTest.lib(UtestPlatform.cpp.obj) : error LNK2001: unresolved external symbol __imp__timeGetTime@0

Related: #11502.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 26, 2020
@JackBoosY JackBoosY marked this pull request as ready for review May 26, 2020 05:40
@JackBoosY JackBoosY requested a review from PhoebeHui May 26, 2020 05:40
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 26, 2020
@dan-shaw dan-shaw added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels May 27, 2020
@JackBoosY JackBoosY requested a review from dan-shaw May 27, 2020 09:36
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 28, 2020
@dan-shaw dan-shaw merged commit 091e190 into microsoft:master May 28, 2020
@JackBoosY JackBoosY deleted the dev/jack/move_cpputest_manuallink branch May 29, 2020 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@dan-shaw dan-shaw Awaiting requested review from dan-shaw

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBoosY @PhoebeHui @dan-shaw