Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python3] Update to Python 3.8 #11708

Merged
merged 3 commits into from
Jun 12, 2020
Merged

[python3] Update to Python 3.8 #11708

merged 3 commits into from
Jun 12, 2020

Conversation

Hoikas
Copy link
Contributor

@Hoikas Hoikas commented Jun 1, 2020

Describe the pull request

  • What does your PR fix?

    • Updates python3 port to 3.8.3.
    • Restores static-linked Python 3 builds.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    • No change.

  • Does your PR follow the maintainer guide?

@msftclas
Copy link

msftclas commented Jun 1, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@MVoz
Copy link
Contributor

MVoz commented Jun 1, 2020

too many dependencies, one python port is not enough

@Hoikas
Copy link
Contributor Author

Hoikas commented Jun 1, 2020 •
edited
Loading

@voskrese I'm not sure I understand what you mean? I am working on an open source project that uses vcpkg as its build system. We are upgrading from Python 2.7 to Python 3 but need the improved initialization features added to support the project's requirements. Specifically, the ability to install a meta_path loader to load Python modules from a packed (read: secure) source.

@MVoz
Copy link
Contributor

MVoz commented Jun 1, 2020

example

vcpkg/ports/vtk/portfile.cmake

Line 39 in c0e7ca3

list(APPEND ADDITIONAL_OPTIONS "-DPython3_LIBRARY_RELEASE:PATH=${CURRENT_INSTALLED_DIR}/lib/python37.lib"

@Hoikas
Copy link
Contributor Author

Hoikas commented Jun 2, 2020

Thanks! I'll look into the other ports.

@Hoikas Hoikas force-pushed the py3.8 branch 3 times, most recently from e086dc8 to 52f5da5 Compare June 2, 2020 04:18
cenit
cenit reviewed Jun 2, 2020
View reviewed changes
ports/python3/portfile.cmake Outdated Show resolved Hide resolved
@Hoikas Hoikas force-pushed the py3.8 branch 3 times, most recently from 6f90387 to bcff109 Compare June 3, 2020 03:07
@Hoikas
Copy link
Contributor Author

Hoikas commented Jun 3, 2020 •
edited
Loading

This is, as far as I can tell ready for review. However, I am stumped by the x64_osx CI failure. The only way I have to access macOS is via GitHub Actions. So, I built both of the commits in this PR using Actions on OSX[1][2]. This succeeded, however, the Azure Pipelines OSX build fails with the following error: ninja: build stopped: subcommand failed. - with no indication as far was what subcommand failed. Any observations or directions about how to fix the issue would be appreciated!

Edit: someone has very kindly helped me to trace down this issue! I will mark this as ready for review again once hyperscan CI on macOS is corrected.

@Hoikas Hoikas marked this pull request as ready for review June 3, 2020 19:43
@Hoikas Hoikas marked this pull request as draft June 3, 2020 23:41
@Hoikas Hoikas force-pushed the py3.8 branch 3 times, most recently from cae1341 to f7f8a29 Compare June 4, 2020 02:20
@Hoikas Hoikas marked this pull request as ready for review June 4, 2020 02:39
@JackBoosY
Copy link
Contributor

Some regressions are not related to this PR. See #11742.

Hoikas
Hoikas commented Jun 5, 2020
View reviewed changes
Copy link
Contributor Author

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @JackBoosY. I hope my comments have answered your concerns.

ports/python3/0001-static-library.patch Show resolved Hide resolved
ports/python3/0001-static-library.patch Show resolved Hide resolved
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines category:port-update The issue is with a library, which is requesting update new revision and removed requires:author-response labels Jun 8, 2020
@dan-shaw dan-shaw merged commit e1783c6 into microsoft:master Jun 12, 2020
@dan-shaw
Copy link
Contributor

Thanks for the PR!

JangBoo pushed a commit to JangBoo/vcpkg that referenced this pull request Jun 18, 2020
@Hoikas @JangBoo
[python3] Update to Python 3.8 (microsoft#11708)
5858bd2 
* [python3] Update to Python 3.8.3.

[vtk] Update to Python 3.8 and fix improper Python3 artifact
specification.

* [python3] Fix static linking, broken in 121faf2.

* [hyperscan] Add missing build dependency (fixes CI on macOS).
@Hoikas Hoikas mentioned this pull request Jul 11, 2020
Closed
@Hoikas Hoikas deleted the py3.8 branch July 11, 2020 03:21
@Hoikas Hoikas mentioned this pull request Jul 13, 2020
Merged
penumbra23 pushed a commit to codespace-dev/vcpkg that referenced this pull request Aug 5, 2020
@Hoikas @penumbra23
[python3] Update to Python 3.8 (microsoft#11708)
7a023da 
* [python3] Update to Python 3.8.3.

[vtk] Update to Python 3.8 and fix improper Python3 artifact
specification.

* [python3] Fix static linking, broken in 121faf2.

* [hyperscan] Add missing build dependency (fixes CI on macOS).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cenit cenit cenit left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Hoikas @msftclas @MVoz @JackBoosY @dan-shaw @cenit