Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python3] Fix building x86-windows-static triplet on VS 2017. #12412

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

Hoikas
Copy link
Contributor

@Hoikas Hoikas commented Jul 13, 2020

This fixes building python3 with the x86-windows-static triplet on Visual Studio 2017, which was unintentionally broken in #11708.

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label Jul 14, 2020
@ras0219-msft ras0219-msft merged commit 8e3c304 into microsoft:master Jul 14, 2020
@ras0219-msft
Copy link
Contributor

Thanks for the fix!

@Hoikas Hoikas deleted the py3-static-vs2017 branch July 14, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants