Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Many ports] Fix invalid character in feature name #12306

Merged
merged 1 commit into from
Jul 8, 2020
Merged

[Many ports] Fix invalid character in feature name #12306

merged 1 commit into from
Jul 8, 2020

Conversation

PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Jul 7, 2020 •
edited
Loading

Fixes #12301

  1. Fix invalid character in feature name in below ports:
    capstone Feature: x86_reduce
    faad2 Feature: build_decoder
    libwebp Feature: vwebp_sdl
    tesseract Feature: cpu_independed training_tools
    vxl Feature: core_imaging

  2. Fix libwebp missing feature option

  3. Improve the feature check for capstone

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 7, 2020
@PhoebeHui PhoebeHui changed the title [Many ports] fix invalid character in feature name [Many ports] Fix invalid character in feature name Jul 7, 2020
@Neumann-A
Copy link
Contributor

why is _ and invalid character? Wouldn't it be better to allow _ ?

@PhoebeHui
Copy link
Contributor Author

I'm not sure, by design? See

vcpkg/toolsrc/src/vcpkg/packagespec.cpp

Line 113 in 6a41626

// TODO: we do not intend underscores to be valid, however there is currently a feature using them

@PhoebeHui PhoebeHui marked this pull request as ready for review July 8, 2020 01:23
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 8, 2020
@ras0219-msft
Copy link
Contributor

We do not want to invite potential user confusion between _ and -; similar to how we do not allow uppercase characters (to avoid confusion between Zlib and zlib.

@ras0219-msft ras0219-msft merged commit 5e8bcc9 into microsoft:master Jul 8, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/fix_invalid_character branch July 14, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tesseract] build failure for feature cpu_independed
4 participants
@PhoebeHui @Neumann-A @ras0219-msft @JackBoosY