Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libpq] Remove broken features #12415

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jul 14, 2020

Remove features due to their dependency are missing :

  • perl
  • kerberos
  • ldap
  • bsd
  • pam

Fixes #12414

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 14, 2020
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jul 14, 2020

In portfile.cmake line 19:

if(VCPKG_TARGET_IS_WINDOWS)
    # on windows libpq seems to only depend on openssl gss(kerberos) and ldap on the soruce site_name
    # the configuration header depends on zlib, nls, uuid, xml, xlst,gss,openssl,icu
    feature_unsupported(readline bonjour libedit systemd llvm)
    feature_not_implemented_yet(uuid)
elseif(VCPKG_TARGET_IS_OSX)
    feature_not_implemented_yet(readline libedit systemd llvm python tcl uuid)
else()
    feature_not_implemented_yet(readline bonjour libedit systemd llvm python tcl uuid)
endif()

All triplets do not support some common features, should they also be deleted?

ports/libpq/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY marked this pull request as ready for review July 15, 2020 02:06
@JackBoosY JackBoosY requested a review from PhoebeHui July 15, 2020 02:07
@ras0219-msft ras0219-msft merged commit bad319d into microsoft:master Jul 15, 2020
@ras0219-msft
Copy link
Contributor

This LGTM.

@JackBoosY JackBoosY deleted the dev/jack/12414 branch July 16, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libpq] Many features dependencies do not exist
3 participants