Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gf] Add the new package GF #12426

Merged
merged 11 commits into from Jul 31, 2020
Merged

[gf] Add the new package GF #12426

merged 11 commits into from Jul 31, 2020

Conversation

ahugeat
Copy link
Contributor

@ahugeat ahugeat commented Jul 14, 2020

Add GF library

  • What does your PR fix?
    None

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    All triplets are supported except for Arm

  • Does your PR follow the maintainer guide?
    Yes

@ghost
Copy link

ghost commented Jul 14, 2020

CLA assistant check
All CLA requirements met.

@LilyWangL LilyWangL self-assigned this Jul 15, 2020
@LilyWangL LilyWangL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 15, 2020
@LilyWangL
Copy link
Contributor

Thanks for posting this issue. gf build failed on triplet x64-windows-static and Linux, MACOS, you can get more error log from this URL: https://dev.azure.com/vcpkg/public/_build/results?buildId=40257&view=artifacts&type=publishedArtifacts

@ahugeat
Copy link
Contributor Author

ahugeat commented Jul 17, 2020

@LilyWangL I'm sorry it took so long to get back to you, but we're working on the library to make it work with x64-windows-static.
Thanks for your commits, I need to do something to accept it?

@LilyWangL
Copy link
Contributor

@LilyWangL I'm sorry it took so long to get back to you, but we're working on the library to make it work with x64-windows-static.
Thanks for your commits, I need to do something to accept it?

Thanks for your reply. gf build failed on x86-windows and x64-windows with the following error:

LINK Pass 1: command "C:\PROGRA~2\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.26.28801\bin\Hostx64\x86\link.exe library\CMakeFiles\gf0.dir\graphics\XUnityBuild.cc.obj /out:library\gf0.dll /implib:library\gf0.lib /pdb:library\gf0.pdb /dll /version:0.17 /machine:X86 /nologo /debug /INCREMENTAL -LIBPATH:D:\installed\x86-windows\lib -LIBPATH:D:\installed\x86-windows\debug\lib library\gfcore0.lib D:\installed\x86-windows\lib\SDL2.lib D:\installed\x86-windows\debug\lib\freetyped.lib D:\installed\x86-windows\debug\lib\zlibd.lib D:\installed\x86-windows\debug\lib\pugixml_d.lib D:\installed\x86-windows\debug\lib\boost_filesystem-vc140-mt-gd.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:library\CMakeFiles\gf0.dir/intermediate.manifest library\CMakeFiles\gf0.dir/manifest.res" failed (exit code 1104) with the following output:
LINK : fatal error LNK1104: cannot open file 'library\gfcore0.lib'
ninja: build stopped: subcommand failed.

And gf build failed on x64-linux with the following error:

CMake Error at /mnt/vcpkg-ci/installed/x64-linux/share/stb/vcpkg-cmake-wrapper.cmake:5 (_find_package):
  By not providing "Findstb.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "stb", but
  CMake did not find one.

  Could not find a package configuration file provided by "stb" with any of
  the following names:

    stbConfig.cmake
    stb-config.cmake

And gf build failed on x64-windows-static with the following error:

LINK : warning LNK4098: defaultlib 'LIBCMT' conflicts with use of other libs; use /NODEFAULTLIB:library
SDL2.lib(SDL_systimer.c.obj) : error LNK2019: unresolved external symbol __imp_timeGetTime referenced in function SDL_GetPerformanceCounter_REAL
SDL2.lib(SDL_systimer.c.obj) : error LNK2019: unresolved external symbol __imp_timeBeginPeriod referenced in function SDL_SetSystemTimerResolution
SDL2.lib(SDL_systimer.c.obj) : error LNK2019: unresolved external symbol __imp_timeEndPeriod referenced in function SDL_SetSystemTimerResolution
SDL2.lib(SDL_windowskeyboard.c.obj) : error LNK2019: unresolved external symbol GetFileVersionInfoSizeA referenced in function IME_GetId
SDL2.lib(SDL_windowskeyboard.c.obj) : error LNK2019: unresolved external symbol GetFileVersionInfoA referenced in function IME_GetId
SDL2.lib(SDL_windowskeyboard.c.obj) : error LNK2019: unresolved external symbol VerQueryValueA referenced in function IME_GetId
SDL2.lib(SDL_windowskeyboard.c.obj) : error LNK2019: unresolved external symbol ImmGetIMEFileNameA referenced in function IME_GetId

If gf doesn't support some triplets now, please add Supports to CONTROL. And use command vcpkg_fail_port_install in portfile.cmake to warn other users Some triplets builds are not supported.

@jube
Copy link
Contributor

jube commented Jul 24, 2020

Hi @LilyWangL,

Looking at the logs, it seems that some of the jobs are not for the gf library. arm is disabled in the CONTROL file (and in portfile.cmake too), these logs are not ours. x64_uwp is the same, it's not our log. And concerning the only build that fails, x64-windows-static, it does not fail because of gf but because of ompl and podofo, which are not dependencies (direct or not) or gf. The rest builds correctly and is ok.

Is there a problem with Azure builds? Or is it our fault? Is it possible to merge this PR?

Regards

@LilyWangL
Copy link
Contributor

Hi @LilyWangL,

Looking at the logs, it seems that some of the jobs are not for the gf library. arm is disabled in the CONTROL file (and in portfile.cmake too), these logs are not ours. x64_uwp is the same, it's not our log. And concerning the only build that fails, x64-windows-static, it does not fail because of gf but because of ompl and podofo, which are not dependencies (direct or not) or gf. The rest builds correctly and is ok.

Is there a problem with Azure builds? Or is it our fault? Is it possible to merge this PR?

Regards

Thia is CI problem, it is not related with this PR. I will rerun failed port

@jube
Copy link
Contributor

jube commented Jul 24, 2020

Thanks a lot @LilyWangL for your valuable help!

@ahugeat ahugeat marked this pull request as ready for review July 24, 2020 18:47
@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 27, 2020
@strega-nil
Copy link
Contributor

@ahugeat would it be possible to rename this port gamedev-framework? gf is a pretty short and generic name for such a new framework.

@LilyWangL LilyWangL added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jul 29, 2020
@jube
Copy link
Contributor

jube commented Jul 29, 2020

After a discussion with @ahugeat, I made the necessary changes to rename gf to gamedev-framework.

@strega-nil
Copy link
Contributor

Awesome, thanks y'all :)

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 31, 2020
@strega-nil strega-nil merged commit 31cf09e into microsoft:master Jul 31, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
* [gf] Add the new package GF

* Update CONTROL

* Update portfile.cmake

* Try to fix failed builds

* fix x64-linux build for vcpkg

* remove nuklear from dependencies

* use vcpkg_fail_port_install to fail early on arm

* fix x64-windows build

* change the name of the source in CONTROL

* change the name of the directory

* fix cmake install directory

Co-authored-by: Lily <47812810+LilyWangL@users.noreply.github.com>
Co-authored-by: Julien Bernard <julien.bernard@univ-fcomte.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants