Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg_build_qmake] Disable multi-threaded build when file fails to open #12752

Merged
merged 2 commits into from
Aug 6, 2020
Merged

[vcpkg_build_qmake] Disable multi-threaded build when file fails to open #12752

merged 2 commits into from
Aug 6, 2020

Conversation

JackBoosY
Copy link
Contributor

Continue PR #12529.

@JackBoosY JackBoosY added info:internal This PR or Issue was filed by the vcpkg team. category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Aug 5, 2020
@JackBoosY
Copy link
Contributor Author

@Neumann-A

@JackBoosY JackBoosY marked this pull request as ready for review August 5, 2020 06:15
@Neumann-A
Copy link
Contributor

@JackBoosY: According to the logs this did not rerun the qt5 build in CI

@Neumann-A
Copy link
Contributor

Probably just update the port-version of qt5-base. That will rebuilt everything qt5 related

@JackBoosY
Copy link
Contributor Author

@Neumann-A That's unexpected.
@strega-nil The pipeline should detect the relevant ports and retest these ports.

@Neumann-A
Copy link
Contributor

@JackBoosY: I think it is because the call is in a cmake file within qt5-base which gets installed and used. It is thus not transparent for vcpkg that the function gets called since qt5-base does not use it. Just increase the port-version of qt5-base for now.

@Neumann-A
Copy link
Contributor

Neumann-A commented Aug 5, 2020 •
edited
Loading

to be more precise vcpkg_build_qmake.cmake is not used by qt5-base due to the configure script calling directly qmake. qt_build_submodule uses vcpkg_build_qmake.cmake but since qt5-base is not dependent on neither vcpkg_build_qmake.cmake nor qt_build_submodule vcpkg does not have a chance detecting that dependency for the other qt5 ports

@ras0219
Copy link
Contributor

ras0219 commented Aug 5, 2020

Hrm, so we need to extend our dep heuristics to scan all files in the port directory instead of just the portfile.cmake.

@strega-nil strega-nil merged commit 5617464 into microsoft:master Aug 6, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix_qt5_components branch August 7, 2020 01:54
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@JackBoosY @hellozee
[vcpkg_build_qmake] Disable multi-threaded build when file fails to o…
48f3a77 
…pen (microsoft#12752)

* Disable multi-threaded build when file fails to open

* re-trigger qt5 test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PhoebeHui PhoebeHui

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JackBoosY @Neumann-A @ras0219 @strega-nil @PhoebeHui