Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qt5 components] Disable parallel build #12529

Merged
merged 10 commits into from
Jul 31, 2020
Merged

[qt5 components] Disable parallel build #12529

merged 10 commits into from
Jul 31, 2020

Conversation

JackBoosY
Copy link
Contributor 

D:/installed/x86-windows/tools/qt5/debug/mkspecs/features/qt_plugin.prf:59: Cannot write file D:\buildtrees\qt5-imageformats\x86-windows-dbg\mkspecs\modules-inst\qt_plugin_qwbmp.pri: Cannot create parent directory
jom: D:\buildtrees\qt5-imageformats\x86-windows-dbg\src\plugins\imageformats\Makefile [sub-wbmp-make_first] Error 3
jom: D:\buildtrees\qt5-imageformats\x86-windows-dbg\src\plugins\Makefile [sub-imageformats-make_first] Error 2
jom: D:\buildtrees\qt5-imageformats\x86-windows-dbg\src\Makefile [sub-plugins-make_first] Error 2
jom: D:\buildtrees\qt5-imageformats\x86-windows-dbg\Makefile [sub-src-make_first] Error 2

Looks like the parallel build caused this problem. Disable it.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 22, 2020
@JackBoosY
Copy link
Contributor Author

@Neumann-A I wish this PR can fix that issue.

@Neumann-A
Copy link
Contributor

I would probably try to switch out jom for nmake instead of completely removing parallel builds. Is imageformats small enough so that the build does not take considerably longer?

@JackBoosY
Copy link
Contributor Author

@Neumann-A Yes, it's very small, I tried to use nmake instead of jom in #8524, but it's not merged yet.

@JackBoosY JackBoosY changed the title [qt5-imageformats] Disable parallel build [qt5 components] Disable parallel build Jul 23, 2020
@JackBoosY JackBoosY marked this pull request as ready for review July 23, 2020 09:43
@JackBoosY JackBoosY requested a review from PhoebeHui July 23, 2020 09:43
JackBoosY
JackBoosY commented Jul 24, 2020
View reviewed changes
ports/qwt/portfile.cmake Outdated Show resolved Hide resolved
ras0219-msft
ras0219-msft requested changes Jul 28, 2020
View reviewed changes
ports/qwt/portfile.cmake Outdated Show resolved Hide resolved
ports/qt5-connectivity/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY mentioned this pull request Jul 29, 2020
Closed
@JackBoosY JackBoosY linked an issue Jul 29, 2020 that may be closed by this pull request
[qt5-imageformats:x64-windows] build failure #12628
Closed
@strega-nil strega-nil added info:reviewed Pull Request changes follow basic guidelines and removed requires:discussion labels Jul 30, 2020
@strega-nil strega-nil mentioned this pull request Jul 31, 2020
Merged
@strega-nil strega-nil merged commit 2b8d5ba into microsoft:master Jul 31, 2020
@strega-nil strega-nil mentioned this pull request Jul 31, 2020
Merged
@JackBoosY JackBoosY deleted the dev/jack/disable_qt5_imageformats_parallel_build branch August 3, 2020 02:15
@Neumann-A Neumann-A mentioned this pull request Aug 3, 2020
Merged
This was referenced Aug 5, 2020
Merged
Merged
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@JackBoosY @ras0219-msft @hellozee
[qt5 components] Disable parallel build (microsoft#12529)
75e22f1 
* [qt5-imageformats] Disable parallel build

* [ompl] Disable parallel configure

* [qt5-connectivity] Disable parallel build

* [qwt] Update hash

* [qt5-location] Disable parallel build

* Update ports/qwt/portfile.cmake

* Update ports/qwt/portfile.cmake

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>

* [qt5] change build method to vcpkg_execute_build_process

* Add condition when there are some file conflicts

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

@PhoebeHui PhoebeHui Awaiting requested review from PhoebeHui

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[qt5-imageformats:x64-windows] build failure
5 participants
@JackBoosY @Neumann-A @strega-nil @ras0219-msft @PhoebeHui