Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curl] Fix static build #12800

Merged

Conversation

NancyLi1013
Copy link
Contributor

Add the condition for -D_USRDLL definition, only needed by dynamic build.

Note: Features are not needed to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 7, 2020
@NancyLi1013 NancyLi1013 marked this pull request as ready for review August 7, 2020 09:15
@NancyLi1013 NancyLi1013 added the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 7, 2020
@NancyLi1013
Copy link
Contributor Author

This PR should be merged after #12758.

…NancyLi/Fix-static-build-for-curl

# Conflicts:
#	ports/curl/CONTROL
@NancyLi1013 NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 10, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 11, 2020
@strega-nil strega-nil merged commit dea7619 into microsoft:master Aug 12, 2020
remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
* [curl] Fix static build

* Add static patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[curl] static build for Windows should not define _USRDLL
3 participants