Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set _USRDLL on a static Windows build #8030

wants to merge 1 commit into from


Copy link

The _USRDLL macro should only be set when building a .dll.

Copy link
Contributor Author

An issue was reported at microsoft/vcpkg#12763 and in vcpkg it was fixed in microsoft/vcpkg#12800 but this version of the fix fits more with the surrounding CMake code.

@bagder bagder added cmake Windows Windows-specific labels Nov 17, 2021
Copy link

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfectly reasonable to me!

@bagder bagder closed this in f99a4c7 Nov 18, 2021
Copy link

bagder commented Nov 18, 2021


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cmake Windows Windows-specific

Successfully merging this pull request may close these issues.

None yet

2 participants