Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg_configure_cmake] Pass CMAKE_DISABLE_SOURCE_CHANGES to all ports by default #12846

Merged
merged 7 commits into from
Sep 1, 2020
Merged

[vcpkg_configure_cmake] Pass CMAKE_DISABLE_SOURCE_CHANGES to all ports by default #12846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6dfdcf7
[vcpkg] Pass CMAKE_DISABLE_SOURCE_CHANGES to all ports by default
ras0219-msft Apr 24, 2020
42b4c69
[docs] Regenerate
ras0219-msft Apr 24, 2020
adcfbad
Merge remote-tracking branch 'origin/master' into dev/roschuma/cmake-…
BillyONeal Jun 25, 2020
c00e0c6
Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…
ras0219-msft Aug 10, 2020
d0b0811
Merge remote-tracking branch 'origin/master' into HEAD
BillyONeal Aug 22, 2020
1ee4910
Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…
ras0219-msft Aug 28, 2020
28133ab
Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…
ras0219-msft Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/maintainers/vcpkg_configure_cmake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ This should be specified unless the port is known to not work under Ninja.
Disables running the CMake configure step in parallel.
This is needed for libraries which write back into their source directory during configure.

This also disables CMAKE_DISABLE_SOURCE_CHANGES.

### NO_CHARSET_FLAG
Disables passing `utf-8` as the default character set to `CMAKE_C_FLAGS` and `CMAKE_CXX_FLAGS`.

Expand Down
3 changes: 3 additions & 0 deletions scripts/cmake/vcpkg_configure_cmake.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
## Disables running the CMake configure step in parallel.
## This is needed for libraries which write back into their source directory during configure.
##
## This also disables CMAKE_DISABLE_SOURCE_CHANGES.
##
## ### NO_CHARSET_FLAG
## Disables passing `utf-8` as the default character set to `CMAKE_C_FLAGS` and `CMAKE_CXX_FLAGS`.
##
Expand Down Expand Up @@ -266,6 +268,7 @@ function(vcpkg_configure_cmake)
-DCMAKE_INSTALL_PREFIX=${CURRENT_PACKAGES_DIR}/debug)

if(NINJA_HOST AND CMAKE_HOST_WIN32 AND NOT _csc_DISABLE_PARALLEL_CONFIGURE)
list(APPEND _csc_OPTIONS "-DCMAKE_DISABLE_SOURCE_CHANGES=ON")

vcpkg_find_acquire_program(NINJA)
get_filename_component(NINJA_PATH ${NINJA} DIRECTORY)
Expand Down