[fluidlite] Add new port #13006
Merged
[fluidlite] Add new port #13006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
suggested changes
Aug 20, 2020
|
Hi @Ghabry |
NancyLi1013
added
category:new-port
|
Ignore my "XXX" commits they are just for testing because I can't get UWP installed locally (Internet too slow, Download takes days). |
|
@NancyLi1013 |
NancyLi1013
approved these changes
Aug 21, 2020
NancyLi1013
added
info:reviewed
|
@Ghabry |
|
Thanks for your contribution! |
remz1337
pushed a commit
to remz1337/vcpkg
that referenced
this pull request
Aug 23, 2020
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Aug 25, 2020
Fluidlite, added 3 days ago in microsoft#13006 , tries to install the same files as fluidsynth; it's similar to the 'boringssl' situation. Given that fluidlite doens't have any dependencies, this change disables that one rather than fluidsynth,
BillyONeal
added a commit
that referenced
this pull request
Aug 25, 2020
* Disable fluidlite in CI. Fluidlite, added 3 days ago in #13006 , tries to install the same files as fluidsynth; it's similar to the 'boringssl' situation. Given that fluidlite doens't have any dependencies, this change disables that one rather than fluidsynth, * Add warning message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds a new library "fluidlite".
Biggest advantage: No dependency on glib. Actually no single dependency. Perfect when you just want to work with Soundfonts.
Fluidlite has a API compatible to Fluidsynth but it lacks some features: No built-in audio player, no MIDI file parser. So the main purpose is sampling audio provided by an external midi sequencer library.
I tested x86-windows, x64-windows and x64-windows-static.
The CMakeLists builds on Linux and macOS, but not tested through vcpkg.
No idea what a CI baseline is.
I think so.
I have a question:
The library has no versions, I just used the latest master commit as a version. Is this okay or how is the procedure?