Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable fluidlite in CI. #13125

Merged
merged 2 commits into from Aug 25, 2020
Merged

Conversation

BillyONeal
Copy link
Member

Fluidlite, added 3 days ago in #13006 , tries to install the same files as fluidsynth; it's similar to the 'boringssl' situation. Given that fluidlite doens't have any dependencies, this change disables that one rather than fluidsynth,

Starting package 543/1349: fluidsynth:x86-windows
Building package fluidsynth[core]:x86-windows...
-- Downloading https://github.com/FluidSynth/fluidsynth/archive/2393aef3bd0b4e78084cfe16735d402bc1497edd.tar.gz...
-- Extracting source D:/downloads/FluidSynth-fluidsynth-2393aef3bd0b4e78084cfe16735d402bc1497edd.tar.gz
-- Applying patch force-x86-gentables.patch
-- Using source at D:/buildtrees/fluidsynth/src/2bc1497edd-d19340b672.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Installing: D:/packages/fluidsynth_x86-windows/share/fluidsynth/copyright
-- Performing post-build validation
-- Performing post-build validation done
Stored binary cache: W:\67\67c77d45b2c7b460f24349792075d19b9a2b218f.zip
Building package fluidsynth[core]:x86-windows... done
Installing package fluidsynth[core]:x86-windows...
The following files are already installed in D:/installed/x86-windows and are in conflict with fluidsynth:x86-windows

Installed by fluidlite:x86-windows
    include/fluidsynth/gen.h
    include/fluidsynth/log.h
    include/fluidsynth/misc.h
    include/fluidsynth/mod.h
    include/fluidsynth/settings.h
    include/fluidsynth/sfont.h
    include/fluidsynth/synth.h
    include/fluidsynth/types.h
    include/fluidsynth/version.h
    include/fluidsynth/voice.h

Elapsed time for package fluidsynth:x86-windows: 46.12 s

Fluidlite, added 3 days ago in microsoft#13006 , tries to install the same files as fluidsynth; it's similar to the 'boringssl' situation. Given that fluidlite doens't have any dependencies, this change disables that one rather than fluidsynth,
@BillyONeal BillyONeal added the category:infrastructure Pertaining to the CI/Testing infrastrucutre label Aug 25, 2020
@BillyONeal
Copy link
Member Author

/cc @Ghabry

@JackBoosY
Copy link
Contributor

Should we add warning or error messages in portfile.cmake to warn users about conflicts?

@BillyONeal
Copy link
Member Author

Should we add warning or error messages in portfile.cmake to warn users about conflicts?

In this case I think we're OK without it because these 2 libraries appear somewhat specialized and it's unlikely that a user is going to want them both at once. We do have a warning like that for boringssl but that's because so many libraries list openssl as an explicit dependency, but nothing declares fluidsynth as an explicit dependency.

On the other hand I can see an argument that we should be consistent about it....

@BillyONeal
Copy link
Member Author

Added warning message
image

@Ghabry
Copy link
Contributor

Ghabry commented Aug 25, 2020

Oh. Yeah, sorry. I didn't consider this conflict. Disable it.

There is no use case for both libs at once (you only pick lite when you don't want this huge glib dependency)

@BillyONeal BillyONeal merged commit 05635bd into microsoft:master Aug 25, 2020
@BillyONeal BillyONeal deleted the disable_fluidlite branch August 25, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants