Delete use of vcpkg_test_cmake and vcpkg_common_functions. #13065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicroms
approved these changes
Aug 21, 2020
ras0219
suggested changes
Aug 21, 2020
| @@ -1,51 +0,0 @@ | |||
| include(execute_process) | |||
There was a problem hiding this comment.
We should leave stubs behind for backwards compatibility with previous ports -- when we enable versioning, users will be able to access them (and we recommend they do so today anyway via git checkout <sha> -- blah).
| ## ### MODULE | ||
| ## Indicates that the library expects to be found via built-in CMake targets. | ||
| ## | ||
| function(vcpkg_test_cmake) |
There was a problem hiding this comment.
We should leave a stub behind for compatibility.
BillyONeal
changed the title
|
LGTM once DO NOT MERGE has been unmerged :) |
|
In fact, I am thinking of rewriting vcpkg_test_cmake and adding a common method for test generated libraries. |
|
@JackBoosY maybe your test can be applied automatically to every port without any command from portfile? That would be awesome |
…dd option to prohibit use of these deprecated features.
|
Reviewing the second commit by itself is suggested since all the tool changes are in there. |
# Conflicts: # ports/liblinear/portfile.cmake # ports/librsync/portfile.cmake
# Conflicts: # ports/capnproto/portfile.cmake # ports/concurrentqueue/portfile.cmake # ports/decimal-for-cpp/portfile.cmake # ports/fuzzylite/portfile.cmake # ports/modp-base64/portfile.cmake # ports/readerwriterqueue/portfile.cmake # ports/refprop-headers/portfile.cmake
# Conflicts: # ports/7zip/portfile.cmake # ports/muparser/portfile.cmake # ports/nmslib/portfile.cmake
ras0219
pushed a commit
to ras0219/vcpkg
that referenced
this pull request
Oct 9, 2020
Cherry-picked from microsoft#13065
# Conflicts: # ports/aixlog/portfile.cmake # ports/antlr4/portfile.cmake # ports/chakracore/portfile.cmake # ports/cppwinrt/portfile.cmake # ports/crc32c/portfile.cmake # ports/fastcdr/portfile.cmake # ports/freetds/portfile.cmake # ports/jack2/portfile.cmake # ports/jbig2dec/portfile.cmake # ports/libgeotiff/portfile.cmake # ports/libnoise/portfile.cmake # ports/libp7-baical/portfile.cmake # ports/libp7client/portfile.cmake # ports/libsamplerate/portfile.cmake # ports/nvtt/portfile.cmake # ports/qca/portfile.cmake # ports/snowhouse/portfile.cmake # ports/taocpp-json/portfile.cmake
# Conflicts: # ports/wangle/portfile.cmake
|
Merged because all failures were in the baseline. |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTROL files are intentionally not updated because this change should not affect callers of
vcpkg upgrade.vcpkg_test_cmakeis a no-op that was usually commented out and has been slowly getting deleted.vcpkg_common_functionswas a no-op because we already provide those ambiently inportfile.cmake.