Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Fix upgrade for port-version #13069

Merged
merged 3 commits into from
Aug 25, 2020
Merged

[vcpkg] Fix upgrade for port-version #13069

merged 3 commits into from
Aug 25, 2020

Conversation

strega-nil
Copy link
Contributor

The existing code only checked the version, whereas we should be checking both

Fixes #12796
cc @cenit

@strega-nil
[vcpkg] Fix upgrade for port-version
eaabfd0 
The existing code only checked the version, whereas we should be checking both

Fixes microsoft#12796
cc @cenit
@ras0219
Copy link
Contributor

ras0219 commented Aug 21, 2020 •
edited
Loading

Was Update::find_outdated_packages(provider, status_db); already fixed separately? (This PR only addresses the case when the user specifies a package vcpkg update zlib).

@BillyONeal
Copy link
Member

How do you like BillyONeal@2acaf72 ?

@BillyONeal BillyONeal mentioned this pull request Aug 22, 2020
Closed
@strega-nil
Copy link
Contributor Author

@ras0219 yeah it was fixed previously.

@strega-nil strega-nil mentioned this pull request Aug 22, 2020
Merged
@strega-nil
Copy link
Contributor Author

strega-nil commented Aug 22, 2020 •
edited
Loading

CI failure fixed by #13087

@BillyONeal BillyONeal mentioned this pull request Aug 23, 2020
Closed
@JackBoosY JackBoosY added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. labels Aug 24, 2020
@JackBoosY JackBoosY linked an issue Aug 24, 2020 that may be closed by this pull request
Allow upgrading to new revision of port. #13037
Closed
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 24, 2020
@BillyONeal
Copy link
Member

Nicole asked me to push my edits to this PR out of line.

@BillyONeal
Copy link
Member

The fluidsynth failure is fixed by #13125 ; I won't wait for a clean build here if that's the only failure since there's no point.

@BillyONeal BillyONeal merged commit dea7d75 into microsoft:master Aug 25, 2020
@BillyONeal
Copy link
Member

Thanks for your help!

@strega-nil strega-nil deleted the fix-upgrade branch September 10, 2020 21:21
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@strega-nil @BillyONeal
[vcpkg] Fix upgrade for port-version (microsoft#13069)
7fb243e 
Co-authored-by: Billy Robert O'Neal <bion@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow upgrading to new revision of port. [vcpkg] upgrade bug
5 participants
@strega-nil @ras0219 @BillyONeal @PhoebeHui @JackBoosY