[mpc/mpfr] Add new port / update mpfr #13081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BillyONeal: depends VM update: 2c2f1e4 . AX_PTHREAD missing. https://www.gnu.org/software/autoconf-archive/ax_pthread.html |
JackBoosY
added
category:new-port
NancyLi1013
suggested changes
Aug 24, 2020
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
JackBoosY
approved these changes
Aug 24, 2020
JackBoosY
added
depends:vm-update
NancyLi1013
approved these changes
Aug 25, 2020
|
mipr:x64-linux: |
|
@NancyLi1013: Why requires author-response? autoconf-archive is missing which is why the error is there. See comment #13081 (comment) |
|
Thanks for your reply. @Neumann-A |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The failure on x86-windows: |
|
@NancyLi1013: Probably due to the changes to msys. Will only touch it if linux vm has the required deps installed otherwise CI will just be red any way. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
Although I installed these all 248 ports before install icu, I still can't repro this regression. |
|
Install scintilla before install icu, this regression can't repro too. @BillyONeal Do you have any suggestions to repro this? |
|
log about icu regression: |
|
Yeah green ... but i am curious what happened to the regression |
JackBoosY
approved these changes
Jan 19, 2021
|
@Neumann-A Anyway, I recorded that in this PR. |
vicroms
reviewed
Jan 19, 2021
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "name": "gmp", | |||
| "version-string": "6.2.1-2", | |||
| "version-string": "6.2.1", | |||
There was a problem hiding this comment.
Since this already uses a manifest file, why not use version-semver or version versioning schemes?
There was a problem hiding this comment.
Why should it? This is a vcpkg internal update.
As such port-version is the correct thing and should have been from the beginning.
There was a problem hiding this comment.
In my opinion we should start switching packages to their correct versioning schemes.
Since "version-string" are non-orderable (except by their port version number) by design, continuing to use them will seriously limit the usefulness of "version>=" constraints.
There was a problem hiding this comment.
I am just doing what vcpkg x-add-version does. If you want "version": "6.2.1", here please tell/teach the command to do that.
vicroms
approved these changes
Jan 19, 2021
JackBoosY
approved these changes
Jan 22, 2021
full log Will try to rerun the test. |
|
It seems a baseline regression. |
|
Already merged from master. |
dan-shaw
approved these changes
Jan 25, 2021
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Jan 25, 2021
[mpc/mpfr] Add new port / update mpfr (microsoft#13081)
|
@BillyONeal this is an example of what I was trying to discuss with you earlier: this PR changed a dependency, from mpir to gmp, without any additional note, and broke downstream check in CI for other ports without anyone noticing. The problem is that now, due to already accepted failures in baseline, all ports that were depending on mpir and mpfr are now broken by default, since gmp cannot be installed if mpir is installed. TL;DR : try to install openmvs now. It depends on both gmp and mpir and so it's bound to fail. It was not before. It is completely untested by ci now, and it was not before. This is only an example. |
|
That's similar to what I experience always with the opencv port. Somehow, externally it gets broken and no-one gets notified about that. That just means more work to fix parallel unrelated ports every time I want to update it (and make it really work of course, not just pretending it) |
probably due to #13081 (comment). Need to install Trying to fix it in #15860 but I really need an inverse dependency lookup for those issues (e.g. |
|
Yes, you should put a note in the port file for linux and osx to install autoconf-archive (both on apt and in brew). |
Closed
Sungeun0318
pushed a commit
to Sungeun0318/-vcpkg
that referenced
this pull request
May 15, 2024
* Add meson from microsoft/vcpkg#12860 * Add autoconf-archive from microsoft/vcpkg#13081 * Add kf5windowsystem libs from microsoft/vcpkg#13467 * Open the FTP and SFTP ports from microsoft/vcpkg#14412 * Add libxcb-util0-dev from microsoft/vcpkg#14678 * Add libasound2-dev from microsoft/vcpkg#14774 * Remove no longer necessary apt-mark calls. * Update nasm on Linux. * Fix longstanding bug where Storage was publicly accessible and change to generate SAS token rather than File Share * Delete no longer necessary azure storage firewall rules. * Install the newer Windows SDK with the VS installer instead of manually. * Install the VS2015 and VS2017 compilers. * Update Powershell-Core to 7.1.0. * Update source of WDK. * Update pools. * [opentracing] Repair arm64-windows failures caused by mojibake in `expected.hpp` and errors in opentracing-cpp's lint for arm64 where it thinks exceptions are disabled when they are enabled. Fixes: C:\Dev\vcpkg\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\3rd_party\include\opentracing/expected/expected.hpp(1): warning C4828: The file contains a character starting at offset 0x4a77 that is illegal in the current source character set (codepage 65001). Fixes: D:\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\include\opentracing/tracer.h:223:5: error: cannot use 'try' with exceptions disabled [clang-diagnostic-error] try { ^ * [mmloader] Patch out overrides of CMAKE_C_FLAGS and CMAKE_CXX_FLAGS that inserted /WX. Note that this port sets /GS-, possibly because it may be for authoring shellcode. * Bump storage API version to 2020-04-08.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
might depend on #12936 if windows CI fails