Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rtaudio] Add new port #14774

Merged
merged 4 commits into from Dec 1, 2020
Merged

[rtaudio] Add new port #14774

merged 4 commits into from Dec 1, 2020

Conversation

chausner
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

This adds a new port for the latest release of RtAudio. Fixes #11183.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Triplets x86-windows, x86-windows-static, x64-windows and x64-windows-static have been tested. Other platforms are untested.

Yes

@PhoebeHui PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 26, 2020
@PhoebeHui PhoebeHui changed the title Add rtaudio 5.1.0 [rtaudio] Add new port Nov 26, 2020
@chausner
Copy link
Contributor Author

UWP builds seem to fail due to missing APIs. Even though I think WASAPI should be supported by UWP in theory, at least the code is currently not compatible (COM functions like CoInitialize are not found). So I marked UWP as not supported in the manifest for now.

Builds on Linux fail in the CI because RtAudio by default builds against ALSA on Linux for which the dev libraries seem to be missing. I could build the package successfully on Ubuntu 20.04 after installing:

sudo apt-get install libasound2-dev

So I guess this is fine but we probably still want to disable Linux CI builds since the build is expected to fail there. Shall I add supports: "!linux" to the manifest?

@PhoebeHui PhoebeHui added the depends:vm-update PR contains changes to the VM provisioning scripts label Nov 27, 2020
PhoebeHui
PhoebeHui requested changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

For the package that required on Linux, I will confirm when to deploy the package on Linux CI testing machines.

ports/rtaudio/LICENSE Show resolved Hide resolved
@strega-nil
Copy link
Contributor

This means that we should add rtaudio:x64-linux=fail to ci.baseline.txt.

@chausner
Copy link
Contributor Author

chausner commented Dec 1, 2020

This means that we should add rtaudio:x64-linux=fail to ci.baseline.txt.

Done in f107104

@strega-nil strega-nil merged commit 40d7782 into microsoft:master Dec 1, 2020
@strega-nil
Copy link
Contributor

Thanks @chausner !

@chausner chausner deleted the rtaudio-5.1.0 branch December 1, 2020 20:53
@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 2, 2020
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Dec 22, 2020
@BillyONeal
Add libasound2-dev from microsoft#14774
ebbe1c4
BillyONeal added a commit that referenced this pull request Dec 22, 2020
@BillyONeal
[opentracing] Update VMs 2020-12 (#15151)
229f537 
* Add meson from #12860

* Add autoconf-archive from #13081

* Add kf5windowsystem libs from #13467

* Open the FTP and SFTP ports from #14412

* Add libxcb-util0-dev from #14678

* Add libasound2-dev from #14774

* Remove no longer necessary apt-mark calls.

* Update nasm on Linux.

* Fix longstanding bug where Storage was publicly accessible and change to generate SAS token rather than File Share

* Delete no longer necessary azure storage firewall rules.

* Install the newer Windows SDK with the VS installer instead of manually.

* Install the VS2015 and VS2017 compilers.

* Update Powershell-Core to 7.1.0.

* Update source of WDK.

* Update pools.

* [opentracing] Repair arm64-windows failures caused by mojibake in `expected.hpp` and errors in opentracing-cpp's lint for arm64 where it thinks exceptions are disabled when they are enabled.

Fixes:
C:\Dev\vcpkg\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\3rd_party\include\opentracing/expected/expected.hpp(1): warning C4828: The file contains a character starting at offset 0x4a77 that is illegal in the current source character set (codepage 65001).

Fixes:
D:\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\include\opentracing/tracer.h:223:5: error: cannot use 'try' with exceptions disabled [clang-diagnostic-error]
    try {
    ^

* [mmloader] Patch out overrides of CMAKE_C_FLAGS and CMAKE_CXX_FLAGS that inserted /WX.

Note that this port sets /GS-, possibly because it may be for authoring shellcode.

* Bump storage API version to 2020-04-08.
@BillyONeal BillyONeal removed the depends:vm-update PR contains changes to the VM provisioning scripts label Dec 22, 2020
ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
@BillyONeal
[opentracing] Update VMs 2020-12 (microsoft#15151)
c712063 
* Add meson from microsoft#12860

* Add autoconf-archive from microsoft#13081

* Add kf5windowsystem libs from microsoft#13467

* Open the FTP and SFTP ports from microsoft#14412

* Add libxcb-util0-dev from microsoft#14678

* Add libasound2-dev from microsoft#14774

* Remove no longer necessary apt-mark calls.

* Update nasm on Linux.

* Fix longstanding bug where Storage was publicly accessible and change to generate SAS token rather than File Share

* Delete no longer necessary azure storage firewall rules.

* Install the newer Windows SDK with the VS installer instead of manually.

* Install the VS2015 and VS2017 compilers.

* Update Powershell-Core to 7.1.0.

* Update source of WDK.

* Update pools.

* [opentracing] Repair arm64-windows failures caused by mojibake in `expected.hpp` and errors in opentracing-cpp's lint for arm64 where it thinks exceptions are disabled when they are enabled.

Fixes:
C:\Dev\vcpkg\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\3rd_party\include\opentracing/expected/expected.hpp(1): warning C4828: The file contains a character starting at offset 0x4a77 that is illegal in the current source character set (codepage 65001).

Fixes:
D:\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\include\opentracing/tracer.h:223:5: error: cannot use 'try' with exceptions disabled [clang-diagnostic-error]
    try {
    ^

* [mmloader] Patch out overrides of CMAKE_C_FLAGS and CMAKE_CXX_FLAGS that inserted /WX.

Note that this port sets /GS-, possibly because it may be for authoring shellcode.

* Bump storage API version to 2020-04-08.
BillyONeal added a commit to microsoft/vcpkg-tool that referenced this pull request Jan 4, 2021
@BillyONeal
[opentracing] Update VMs 2020-12 (#15151)
76b9f66 
* Add meson from microsoft/vcpkg#12860

* Add autoconf-archive from microsoft/vcpkg#13081

* Add kf5windowsystem libs from microsoft/vcpkg#13467

* Open the FTP and SFTP ports from microsoft/vcpkg#14412

* Add libxcb-util0-dev from microsoft/vcpkg#14678

* Add libasound2-dev from microsoft/vcpkg#14774

* Remove no longer necessary apt-mark calls.

* Update nasm on Linux.

* Fix longstanding bug where Storage was publicly accessible and change to generate SAS token rather than File Share

* Delete no longer necessary azure storage firewall rules.

* Install the newer Windows SDK with the VS installer instead of manually.

* Install the VS2015 and VS2017 compilers.

* Update Powershell-Core to 7.1.0.

* Update source of WDK.

* Update pools.

* [opentracing] Repair arm64-windows failures caused by mojibake in `expected.hpp` and errors in opentracing-cpp's lint for arm64 where it thinks exceptions are disabled when they are enabled.

Fixes:
C:\Dev\vcpkg\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\3rd_party\include\opentracing/expected/expected.hpp(1): warning C4828: The file contains a character starting at offset 0x4a77 that is illegal in the current source character set (codepage 65001).

Fixes:
D:\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\include\opentracing/tracer.h:223:5: error: cannot use 'try' with exceptions disabled [clang-diagnostic-error]
    try {
    ^

* [mmloader] Patch out overrides of CMAKE_C_FLAGS and CMAKE_CXX_FLAGS that inserted /WX.

Note that this port sets /GS-, possibly because it may be for authoring shellcode.

* Bump storage API version to 2020-04-08.
Sungeun0318 pushed a commit to Sungeun0318/-vcpkg that referenced this pull request May 15, 2024
@BillyONeal
[opentracing] Update VMs 2020-12 (#15151)
c5692a3 
* Add meson from microsoft/vcpkg#12860

* Add autoconf-archive from microsoft/vcpkg#13081

* Add kf5windowsystem libs from microsoft/vcpkg#13467

* Open the FTP and SFTP ports from microsoft/vcpkg#14412

* Add libxcb-util0-dev from microsoft/vcpkg#14678

* Add libasound2-dev from microsoft/vcpkg#14774

* Remove no longer necessary apt-mark calls.

* Update nasm on Linux.

* Fix longstanding bug where Storage was publicly accessible and change to generate SAS token rather than File Share

* Delete no longer necessary azure storage firewall rules.

* Install the newer Windows SDK with the VS installer instead of manually.

* Install the VS2015 and VS2017 compilers.

* Update Powershell-Core to 7.1.0.

* Update source of WDK.

* Update pools.

* [opentracing] Repair arm64-windows failures caused by mojibake in `expected.hpp` and errors in opentracing-cpp's lint for arm64 where it thinks exceptions are disabled when they are enabled.

Fixes:
C:\Dev\vcpkg\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\3rd_party\include\opentracing/expected/expected.hpp(1): warning C4828: The file contains a character starting at offset 0x4a77 that is illegal in the current source character set (codepage 65001).

Fixes:
D:\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\include\opentracing/tracer.h:223:5: error: cannot use 'try' with exceptions disabled [clang-diagnostic-error]
    try {
    ^

* [mmloader] Patch out overrides of CMAKE_C_FLAGS and CMAKE_CXX_FLAGS that inserted /WX.

Note that this port sets /GS-, possibly because it may be for authoring shellcode.

* Bump storage API version to 2020-04-08.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui requested changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Port Request] RtAudio
4 participants
@chausner @strega-nil @PhoebeHui @BillyONeal