[serd] Add new port #13260
Merged
[serd] Add new port #13260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NancyLi1013
suggested changes
Sep 1, 2020
NancyLi1013
added
category:new-port
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
NancyLi1013
approved these changes
Sep 2, 2020
NancyLi1013
added
info:reviewed
BillyONeal
reviewed
Sep 3, 2020
BillyONeal
added
requires:author-response
and removed
info:reviewed
Co-authored-by: Billy O'Neal <bion@microsoft.com>
|
I see @ras0219 thumb-up'd your comment so I assume that's the right thing. This CMake exports stuff is new to me too :) Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Adds one of the dependencies for [New Port Request] lilv #13211.
Which triplets are supported/not supported? Have you updated the CI baseline?
I have tested
x86-windows,x64-windows, andx64-windows-static; I would expect others to work too. CI all passed, so the CI baseline does not need updating.Does your PR follow the maintainer guide?
I believe so.