Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[croncpp] Added croncpp port #13359

Merged
merged 8 commits into from
Sep 14, 2020
Merged

[croncpp] Added croncpp port #13359

merged 8 commits into from
Sep 14, 2020

Conversation

rkesters
Copy link
Contributor

@rkesters rkesters commented Sep 4, 2020

Describe the pull request

  • What does your PR fix? Created new port for croncpp

  • Which triplets are supported/not supported? all

  • Have you updated the CI baseline? no, but this in the first time adding a new port

  • Does your PR follow the maintainer guide? yes

@rkesters
Copy link
Contributor Author

rkesters commented Sep 5, 2020

@mariusbancila. , FYI - PR to add croncpp to vcpkg

@rkesters rkesters marked this pull request as ready for review September 5, 2020 02:34
@rkesters rkesters changed the title Added croncpp port [croncpp] Added croncpp port Sep 5, 2020
@JonLiu1993 JonLiu1993 added category:new-port The issue is requesting a new library to be added; consider making a PR! info:good-first-issue This issue would be a good issue to get one's feet wet in solving. labels Sep 7, 2020
@JackBoosY JackBoosY removed the info:good-first-issue This issue would be a good issue to get one's feet wet in solving. label Sep 7, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 7, 2020
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

LGTM once my comments are addressed.

ports/croncpp/portfile.cmake Outdated Show resolved Hide resolved
ports/croncpp/portfile.cmake Outdated Show resolved Hide resolved
ports/croncpp/portfile.cmake Show resolved Hide resolved
ports/croncpp/portfile.cmake Outdated Show resolved Hide resolved
ports/croncpp/CONTROL Outdated Show resolved Hide resolved
rkesters and others added 5 commits September 9, 2020 18:10
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
@rkesters
Copy link
Contributor Author

@ras0219-msft Accepted all you changes; expect one, it caused the build to fail.

Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ras0219-msft ras0219-msft merged commit a2c6f1a into microsoft:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants