Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sord] Add new port #13411

Merged
merged 2 commits into from
Sep 9, 2020
Merged

[sord] Add new port #13411

merged 2 commits into from
Sep 9, 2020

Conversation

DomClark
Copy link
Contributor

@DomClark DomClark commented Sep 8, 2020

Describe the pull request

  • What does your PR fix?
    Adds one of the dependencies for [New Port Request] lilv #13211.

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    I have tested x86-windows, x64-windows, and x64-windows-static; I would expect others to work too. The CI baseline has not been updated.

  • Does your PR follow the maintainer guide?
    Yes.

@DomClark DomClark marked this pull request as ready for review September 9, 2020 01:23
@LilyWangL LilyWangL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 9, 2020
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Sep 9, 2020
@ras0219-msft ras0219-msft merged commit 468e82d into microsoft:master Sep 9, 2020
@ras0219-msft
Copy link
Contributor

Looks great to me, thank you for your contribution!

@DomClark DomClark deleted the add-sord-port branch September 10, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants