[boost-context] Fixes error with linker for 32-bit GNU assembler files targeting Windows #13422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to check it now, for all triplets as [this script](https://github.com/microsoft/vcpkg/blob/master/scripts/boost/generate-ports.ps1) will regenerate portfile.cmake with patch for all of them not just for subset.
|
LGTM, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes error with linker for 32-bit GNU assembler files targeting Windows. This is only applying official patch from boostorg/context, but there is no version with it yet (this is merged after 1.74), and it is require for the build to succeed.
Which triplets are supported/not supported? Have you updated the CI baseline?
This will not affect any other triplets except mingw, CI baseline is not updated.
Does your PR follow the maintainer guide?
Yes, it is