[scintilla] Add static linking to Scintilla

[alek-d]

Describe the pull request

• What does your PR fix? Fixes #

Static linking is officially supported by Scintilla. See https://www.scintilla.org/ScintillaDoc.html, at the bottom of the document, section "Building Scintilla". This PR adds static linking on Windows.

• Which triplets are supported/not supported? Have you updated the CI baseline?

Tested successfully:
x64-windows
x64-windows-static
x64-windows-static-md
x86-windows
x86-windows-static
x86-windows-static-md

• Does your PR follow the maintainer guide?

Yes, it does.

[ghost]

All CLA requirements met.

[cenit]

you should not call vcpkg_apply_patches in a portfile.
Please define a symbol referring to the patch file for static or empty for dynamic and then add the PATCHES section to vcpkg_extract_source_archive_ex

[Hoikas]

These changes to the RuntimeLibrary force usage of the static CRT. They should be pulled into a separate patch, conditioned on VCPKG_CRT_LINKAGE.

[alek-d]

Good point. I assumed that static triplets always links CRT statically.
I've separated these two options, and now CRT can be linked dynamically.
Tested with two community triplets x64/x86-windows-static-md – works fine.
Thanks.

[Hoikas]

Thanks! 😄

[Hoikas]

Please include a trailing newline.

[alek-d]

Included.

[ras0219-msft]

Suggested change

	)
	PATCHES ${PATCHES}
	)

You can then conditionally set PATCHES based on VCPKG_CRT_LINKAGE:

if(VCPKG_CRT_LINKAGE STREQUAL "static")
  set(PATCHES 0001-static-build.patch)
else()
  set(PATCHES)
endif()

[alek-d]

Thank you for the tip.

[alek-d]

@ras0219-msft could you please approve the change. I would like to update Scintilla to the newest version in another PR, but this one is hanging for so long.

[cenit]

scintilla:x64-windows-static=fail in ci.baseline.txt, but in reality is also described as skip

            scintilla:x64-windows-static:       skip: 3e9793440929e680a883b0c2d392ba56798acdbb

this PR should fix this problem and let CI test the port maybe?

[alek-d]

@cenit Thanks. ci.baseline.txt updated.

I have a question about other triplets. Maybe all other currently marked as fail should be marked as skip.
Current Scintilla portfile.cmake starts with vcpkg_fail_port_install(ON_TARGET "Linux" "OSX" "UWP").

So, maybe it would be better to just skip those build rather than expecting them to fail?
Should I change to this?

# Currently Scintilla builds only on Windows
scintilla:arm-uwp=skip
scintilla:x64-linux=skip
scintilla:x64-osx=skip
scintilla:x64-uwp=skip

[cenit]

No leave them as fail.
Skip is only for ports conflicting with each other (name conflicts in header or lib filenames)

[alek-d]

Removed vcpkg_copy_pdbs() from portfile.cmake because it is called in vcpkg_install_msbuild().

[ras0219-msft]

LGTM, sorry for the long delay on this PR and thanks for addressing my comment!