Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scintilla] Update to 4.4.5 #13665

Merged
merged 8 commits into from
Sep 24, 2020
Merged

[scintilla] Update to 4.4.5 #13665

merged 8 commits into from
Sep 24, 2020

Conversation

alek-d
Copy link
Contributor

@alek-d alek-d commented Sep 22, 2020

This PR should be merged after #13529

  • What does your PR fix? Fixes #

Update Scintilla to version 4.4.5

  • Which triplets are supported/not supported?

Tested successfully:
x64-windows
x64-windows-static
x64-windows-static-md
x86-windows
x86-windows-static
x86-windows-static-md

  • Have you updated the CI baseline?

Yes and no. This PR should go after #13529 in which CI baseline is updated accordingly.

Yes.

@LilyWangL LilyWangL added the category:port-update The issue is with a library, which is requesting update new revision label Sep 23, 2020
@LilyWangL
Copy link
Contributor

Thanks for your PR. Could you resolve the conflicts?

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 24, 2020
@ras0219-msft ras0219-msft merged commit 9b1c8a7 into microsoft:master Sep 24, 2020
@ras0219-msft
Copy link
Contributor

Thanks for the update!

@alek-d alek-d deleted the sci445 branch September 30, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants