Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg manifest-mode] Fix parallel msbuild failures #13589

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

strega-nil
Copy link
Contributor

@strega-nil strega-nil commented Sep 17, 2020

This changes the vcpkg msbuild targets file to wait for the lock, rather than failing immediately

Also removes the --binarycaching flag, since it's no longer necessary.

Fixes #13530

This changes the vcpkg msbuild targets file to wait for the lock, rather than failing immediately
@JackBoosY JackBoosY self-assigned this Sep 18, 2020
@JackBoosY JackBoosY added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. labels Sep 18, 2020
@ras0219-msft ras0219-msft merged commit 4902a7b into microsoft:master Sep 19, 2020
sipsorcery added a commit to sipsorcery/bitcoin that referenced this pull request Sep 19, 2020
@strega-nil strega-nil deleted the msbuild-failures branch September 30, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manifests, problem with parallel builds
4 participants