Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[polyhook2] Update to new version #13645

Merged
merged 3 commits into from
Sep 28, 2020
Merged

[polyhook2] Update to new version #13645

merged 3 commits into from
Sep 28, 2020

Conversation

stevemk14ebr
Copy link
Contributor

@stevemk14ebr stevemk14ebr commented Sep 22, 2020

Updates polyhook2 to latest. Supports the triples x86-windows, x86-windows-static, x64-windows, x64-windows-static. PR tested locally on my system and all tests pass.

@LilyWangL LilyWangL changed the title Update polyhook2 [polyhook2] Update to new version Sep 22, 2020
@LilyWangL LilyWangL added the category:port-update The issue is with a library, which is requesting update new revision label Sep 22, 2020
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the additional line is removed! Thanks for the PR!

ports/polyhook2/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Sep 24, 2020
@ras0219-msft ras0219-msft added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Sep 24, 2020
@LilyWangL
Copy link
Contributor

Blocked by #13722.

@ras0219-msft ras0219-msft merged commit 84c22a7 into microsoft:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants