Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Fix Windows pipeline's outdated Ninja reference #13722

Merged
merged 1 commit into from
Sep 25, 2020
Merged

[vcpkg] Fix Windows pipeline's outdated Ninja reference #13722

merged 1 commit into from
Sep 25, 2020

Conversation

ras0219-msft
Copy link
Contributor

@ras0219-msft ras0219-msft commented Sep 24, 2020 •
edited
Loading

@ras0219-msft ras0219-msft self-assigned this Sep 24, 2020
@ras0219-msft ras0219-msft added the info:internal This PR or Issue was filed by the vcpkg team. label Sep 24, 2020
@cenit
Copy link
Contributor

cenit commented Sep 24, 2020

@JackBoosY we need to do a similar fix in #12612

@PhoebeHui PhoebeHui added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Sep 25, 2020
@JackBoosY JackBoosY mentioned this pull request Sep 25, 2020
Merged
This was referenced Sep 25, 2020
Merged
Merged
Merged
Merged
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 25, 2020
@JackBoosY
Copy link
Contributor

@cenit The best way is wait for this PR merge.

@PhoebeHui PhoebeHui added category:infrastructure Pertaining to the CI/Testing infrastrucutre and removed category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Sep 25, 2020
This was referenced Sep 25, 2020
Merged
Merged
@LilyWangL LilyWangL mentioned this pull request Sep 25, 2020
Merged
@NancyLi1013 NancyLi1013 mentioned this pull request Sep 25, 2020
Merged
@cenit
Copy link
Contributor

cenit commented Sep 25, 2020

@cenit The best way is wait for this PR merge.

No i mean we will have to change references to CMake there, in the same line @ras0219 changed references to ninja here

This was referenced Sep 25, 2020
Merged
Merged
@JackBoosY JackBoosY mentioned this pull request Sep 25, 2020
Merged
This was referenced Sep 25, 2020
Merged
Merged
Merged
@JackBoosY JackBoosY mentioned this pull request Sep 25, 2020
Closed
@PhoebeHui PhoebeHui mentioned this pull request Sep 25, 2020
Merged
@BillyONeal BillyONeal merged commit 57b3738 into microsoft:master Sep 25, 2020
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Sep 26, 2020
@Jimmy-Hu
Merge pull request #336 from microsoft/master
ab4a370 
[vcpkg] Fix Windows pipeline's outdated Ninja reference (microsoft#13722)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@ras0219-msft ras0219-msft

@PhoebeHui PhoebeHui

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ras0219-msft @cenit @JackBoosY @PhoebeHui @BillyONeal